WebKit export: CSS <position> should never serialize to a single value (

#42112) https://bugs.webkit.org/show_bug.cgi?id=258585
web-platform-tests · Sep 22, 2023 · 2985a99 · 2985a99
1 parent 42d4d50
commit 2985a99
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 27 deletions.
diff --git a/css/css-masking/parsing/mask-position-valid.html b/css/css-masking/parsing/mask-position-valid.html
@@ -11,28 +11,28 @@
 </head>
 <body>
 <script>
-test_valid_value("mask-position", "10%");
+test_valid_value("mask-position", "10%", "10% center");
 test_valid_value("mask-position", "right 30% top 60px");
 test_valid_value("mask-position", "-20% -30px");
-test_valid_value("mask-position", "30px center", "30px");
+test_valid_value("mask-position", "30px center", "30px center");
 test_valid_value("mask-position", "40px top");
 test_valid_value("mask-position", "bottom 10% right 20%", "right 20% bottom 10%");
 test_valid_value("mask-position", "bottom right", "right bottom");
 test_valid_value("mask-position", "center 50px");
-test_valid_value("mask-position", "center bottom", "bottom");
-test_valid_value("mask-position", "center left", "left");
-test_valid_value("mask-position", "left");
+test_valid_value("mask-position", "center bottom", "center bottom");
+test_valid_value("mask-position", "center left", "left center");
+test_valid_value("mask-position", "left", "left center");
 test_valid_value("mask-position", "left bottom");
 test_valid_value("mask-position", "right 40%");
-test_valid_value("mask-position", "top");
-test_valid_value("mask-position", "top center", "top");
-test_valid_value("mask-position", "center", "center");
+test_valid_value("mask-position", "top", "center top");
+test_valid_value("mask-position", "top center", "center top");
+test_valid_value("mask-position", "center", "center center");
 test_valid_value("mask-position", "bottom left, right 20%", "left bottom, right 20%");
-test_valid_value("mask-position", "top, center, left");
+test_valid_value("mask-position", "top, center, left", "center top, center center, left center");
 test_valid_value("mask-position", "20% 0%");
 test_valid_value("mask-position", "0% 0%");
-test_valid_value("mask-position", "0%", ["0%", "0% center"]);
-test_valid_value("mask-position", "0% center", ["0%", "0% center"]);
+test_valid_value("mask-position", "0%", "0% center");
+test_valid_value("mask-position", "0% center");
 test_valid_value("mask-position", "center 0%");
 </script>
 </body>

diff --git a/css/cssom/serialize-values.html b/css/cssom/serialize-values.html
@@ -150,23 +150,7 @@
       return null;
     }
 
-    // A more elegant way of doing this would be better, but for now this exception list handles cases where "center" must be omitted.
     var minimal_results = {
-        "background-position: 5% center": "5%",
-        "background-position: 0.5% center": "0.5%",
-        "background-position: -5% center": "-5%",
-        "background-position: -0.5% center": "-0.5%",
-        "background-position: 0px center": "0px",
-        "background-position: 1px center": "1px",
-        "background-position: 0.1em center": "0.1em",
-        "background-position: 0px center": "0px",
-        "background-position: -1px center": "-1px",
-        "background-position: -0.1em center": "-0.1em",
-        "background-position: left center": "left",
-        "background-position: center top": "top",
-        "background-position: center center": "center",
-        "background-position: center bottom": "bottom",
-        "background-position: right center": "right",
     };
 
     function create_result(propertyName, actual, expected) {