Skip to content

Commit

Permalink
Add a lint rule to check for tests that use the Ahem font but do not
Browse files Browse the repository at this point in the history
include the /fonts/ahem.css stylesheet (which loads this font as a web
font). This prevents tests from assuming that Ahem is installed as a
system font. Also includes some unit tests.

There are a few tests that are incorrectly flagged as violating this
rule, these were added to lint.whitelist.

A bunch of other tests were fixed to load Ahem as a web font.
  • Loading branch information
LukeZielinski committed Sep 6, 2019
1 parent ea47721 commit 2bca5e0
Show file tree
Hide file tree
Showing 60 changed files with 259 additions and 5 deletions.
1 change: 1 addition & 0 deletions css/CSS2/linebox/inline-negative-margin-001.html
Expand Up @@ -6,6 +6,7 @@
<link rel="help" href="https://crbug.com/979894">
<link rel="help" href="https://drafts.csswg.org/css2/visudet.html#inline-width">
<link rel="author" title="Koji Ishii" href="mailto:kojii@chromium.org">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
html, body { margin: 0; }
div {
Expand Down
4 changes: 2 additions & 2 deletions css/CSS2/normal-flow/max-width-107.xht
Expand Up @@ -14,7 +14,7 @@

<meta content="ahem" name="flags" />
<meta content="'max-width' specifies a fixed maximum used width. If the used width is greater than max-width, then the computed value of max-width is used as the computed value for width." name="assert" />

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style type="text/css"><![CDATA[
div
{
Expand Down Expand Up @@ -43,4 +43,4 @@
<div id="control-green-overlapping">X</div>

</body>
</html>
</html>
1 change: 1 addition & 0 deletions css/css-fonts/font-family-name-025-ref.html
Expand Up @@ -3,6 +3,7 @@
<link rel="help" href="http://www.w3.org/TR/CSS21/fonts.html#propdef-font-family" />
<link rel="help" href="http://www.w3.org/TR/CSS21/fonts.html#font-family-prop" />
<meta name="assert" content="The 'font-family' property set to and installed font renders the appropriate font." />
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style type="text/css">
body { font-size: 36px; }
span#verify { font-family: CSSTest Verify; }
Expand Down
1 change: 1 addition & 0 deletions css/css-fonts/font-family-name-025.html
Expand Up @@ -5,6 +5,7 @@
<link rel="help" href="http://www.w3.org/TR/css-fonts-3/#font-family-prop" />
<link rel="match" href="font-family-name-025-ref.html" />
<meta name="assert" content="The 'font-family' property set to and installed font renders the appropriate font. Postscript name should not match." />
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
body { font-size: 36px; }
span#verify { font-family: CSSTest Verify; }
Expand Down
1 change: 1 addition & 0 deletions css/css-fonts/parsing/font-style-computed.html
Expand Up @@ -8,6 +8,7 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/computed-testcommon.js"></script>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#target {
font-family: Ahem;
Expand Down
Expand Up @@ -4,6 +4,7 @@
<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
<link rel="help" title="10.2 Aligning with auto margins" href="https://drafts.csswg.org/css-grid/#auto-margins">
<meta name="assert" content="The 'top' and 'bottom' margins must be recomputed whenever the grid item's height changes.">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#grid {
display: grid;
Expand Down
Expand Up @@ -4,6 +4,7 @@
<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
<link rel="help" title="10.2 Aligning with auto margins" href="https://drafts.csswg.org/css-grid/#auto-margins">
<meta name="assert" content="The 'top' and 'bottom' margins must be recomputed whenever the grid item's height changes.">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#grid {
display: grid;
Expand Down
Expand Up @@ -5,6 +5,7 @@
<link rel="help" title="10.2 Aligning with auto margins" href="https://drafts.csswg.org/css-grid/#auto-margins">
<link rel="match" href="../reference/grid-block-axis-alignment-auto-margins-008-ref.html">
<meta name="assert" content="The 'top' and 'bottom' margins must be recomputed after the grid's intrinsic size is determined.">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#grid {
display: grid;
Expand Down
Expand Up @@ -4,6 +4,7 @@
<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
<link rel="help" title="10.2 Aligning with auto margins" href="https://drafts.csswg.org/css-grid/#auto-margins">
<meta name="assert" content="The 'left' and 'right' margins must be recomputed whenever the grid items's width changes.">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#grid {
display: grid;
Expand Down Expand Up @@ -35,6 +36,7 @@
<div id="item2">XXXXX</div>
</div>
<script>
document.fonts.ready.then(() => {
item1.setAttribute("data-offset-x", "50");
item2.setAttribute("data-offset-x", "325");
checkLayout('#grid');
Expand All @@ -44,4 +46,5 @@
item1.setAttribute("data-offset-x", "50");
item2.setAttribute("data-offset-x", "275");
checkLayout('#grid');
});
</script>
Expand Up @@ -4,6 +4,7 @@
<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
<link rel="help" title="10.2 Aligning with auto margins" href="https://drafts.csswg.org/css-grid/#auto-margins">
<meta name="assert" content="The 'left' and 'right' margins must be recomputed whenever the grid items's width changes.">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#grid {
display: grid;
Expand Down Expand Up @@ -34,6 +35,7 @@
<div id="item2">XX</div>
</div>
<script>
document.fonts.ready.then(() => {
item1.setAttribute("data-offset-x", "80");
item2.setAttribute("data-offset-x", "340");
checkLayout('#grid');
Expand All @@ -43,4 +45,5 @@
item1.setAttribute("data-offset-x", "50");
item2.setAttribute("data-offset-x", "325");
checkLayout('#grid');
});
</script>
Expand Up @@ -5,6 +5,7 @@
<link rel="help" title="10.2 Aligning with auto margins" href="https://drafts.csswg.org/css-grid/#auto-margins">
<link rel="match" href="../reference/grid-inline-axis-alignment-auto-margins-008-ref.html">
<meta name="assert" content="The 'left' and 'right' margins must be recomputed after the grid's intrinsic size is determined.">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#grid {
display: grid;
Expand Down
Expand Up @@ -2,6 +2,7 @@
<meta charset="utf-8">
<title>CSS Grid Layout Reference: Aligning grid items using 'auto' margins</title>
<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#grid {
display: grid;
Expand Down
Expand Up @@ -2,6 +2,7 @@
<meta charset="utf-8">
<title>CSS Grid Layout Reference: Aligning grid items using 'auto' margins</title>
<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#grid {
display: grid;
Expand Down
1 change: 1 addition & 0 deletions css/css-masking/clip-path/clip-path-inline-001.html
Expand Up @@ -4,6 +4,7 @@
<link rel="help" href="https://www.w3.org/TR/css-masking-1/#the-clip-path" title="5.1 Clipping Shape: the clip-path property">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<meta content="ahem" name="flags">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
body {
overflow: hidden;
Expand Down
1 change: 1 addition & 0 deletions css/css-masking/clip-path/clip-path-inline-002.html
Expand Up @@ -4,6 +4,7 @@
<link rel="help" href="https://www.w3.org/TR/css-masking-1/#the-clip-path" title="5.1 Clipping Shape: the clip-path property">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<meta content="ahem" name="flags">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
body {
overflow: hidden;
Expand Down
1 change: 1 addition & 0 deletions css/css-masking/clip-path/clip-path-inline-003.html
Expand Up @@ -4,6 +4,7 @@
<link rel="help" href="https://www.w3.org/TR/css-masking-1/#the-clip-path" title="5.1 Clipping Shape: the clip-path property">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<meta content="ahem" name="flags">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
body {
overflow: hidden;
Expand Down
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>Non-reference case for text-underline-offset</title>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#main {
margin: 2em;
Expand Down
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>Reference case for text-underline-offset</title>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#main{
border-bottom: 1px solid cyan;
Expand Down
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>Non-reference case for text-underline-offset</title>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#text{
border: black dashed;
Expand Down
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>Reference case for text-underline-offset</title>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#text{
border: black dashed;
Expand Down
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>Reference case for text-underline-offset</title>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
span{
font: 20px/1 Ahem;
Expand Down
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8">
<title>Reference case for text-underline-offset</title>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div{
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text-decor/text-underline-offset-001.html
Expand Up @@ -8,6 +8,7 @@
<link rel="author" title="Mozilla" href="https://www.mozilla.org">
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#underline-offset">
<link rel="mismatch" href="reference/text-underline-offset-001-notref.html">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#main {
margin: 2em;
Expand Down
1 change: 1 addition & 0 deletions css/css-text-decor/text-underline-offset-002.html
Expand Up @@ -7,6 +7,7 @@
<link rel="author" title="Mozilla" href="https://www.mozilla.org">
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#underline-offset">
<link rel="match" href="reference/text-underline-offset-002-ref.html">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
#main{
border-bottom: 1px solid cyan;
Expand Down
1 change: 1 addition & 0 deletions css/css-text-decor/text-underline-offset-scroll-001.html
Expand Up @@ -9,6 +9,7 @@
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#underline-offset">
<link rel="match" href="reference/text-underline-offset-scroll-001-ref.html">
<link rel="mismatch" href="reference/text-underline-offset-scroll-001-notref.html">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
/*
* Testing to make sure that positioning the underline
Expand Down
1 change: 1 addition & 0 deletions css/css-text-decor/text-underline-offset-vertical-001.html
Expand Up @@ -8,6 +8,7 @@
<link rel="author" title="Mozilla" href="https://www.mozilla.org">
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#underline-offset">
<link rel="match" href="reference/text-underline-offset-vertical-001-ref.html">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
span{
margin-left: 5em;
Expand Down
1 change: 1 addition & 0 deletions css/css-text-decor/text-underline-offset-vertical-002.html
Expand Up @@ -8,6 +8,7 @@
<link rel="author" title="Mozilla" href="https://www.mozilla.org">
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#underline-offset">
<link rel="match" href="reference/text-underline-offset-vertical-002-ref.html">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div{
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/hyphens/hyphens-overflow-001.html
Expand Up @@ -3,6 +3,7 @@
<link rel="match" href="reference/hyphens-overflow-001-ref.html">
<link rel="help" href="https://drafts.csswg.org/css-text-3/#hyphens-property">
<link rel="author" href="mailto:kojii@chromium.org">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font-size: 10px;
Expand Down
@@ -1,4 +1,5 @@
<!DOCTYPE html>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font-size: 10px;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/tab-size/tab-size.html
Expand Up @@ -2,6 +2,7 @@
<meta charset="utf-8">
<title>Test: CSS value type of the CSS property 'tab-size'</title>
<link rel="help" href="https://drafts.csswg.org/css-text-3/#tab-size-property">
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
body {
font-family: Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-001.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space at the beginning of the line are breaking opportunities when white-space is pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 50px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-002.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should be breaking opportunities when white-space is pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 25px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-003.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should be breaking opportunities when white-space is pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 25px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-004.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should not be collapsed, honoring white-space: pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-005.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should not be collapsed, honoring white-space: pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-006.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should not be collapsed, honoring white-space: pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-007.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should not be collapsed, honoring white-space: pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-008.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should not be collapsed, honoring white-space: pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-009.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should not be collapsed, honoring white-space: pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-010.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should not be collapsed, honoring white-space: pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-011.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should not be collapsed, honoring white-space: pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-012.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should be breaking opportunities when white-space is pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 25px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-013.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should be breaking opportunities when white-space is pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 25px/1 Ahem;
Expand Down
1 change: 1 addition & 0 deletions css/css-text/white-space/pre-wrap-leading-spaces-014.html
Expand Up @@ -8,6 +8,7 @@
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="Preserved white space after forced breaks become leading white-spaces and should be breaking opportunities when white-space is pre-wrap.">

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 20px/1 Ahem;
Expand Down
Expand Up @@ -3,6 +3,7 @@
<title>CSS test Reference</title>
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />

<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
div {
font: 25px/1 Ahem;
Expand Down

0 comments on commit 2bca5e0

Please sign in to comment.