Skip to content

Commit

Permalink
[PE] Don't truncate table cell's padding
Browse files Browse the repository at this point in the history
Truncation caused inadequate logical width when padding is like 1.7px.

Bug: 817342
Change-Id: Ibdb76cc528cc7e04801fe65409bb8f60e5ac69a5
Reviewed-on: https://chromium-review.googlesource.com/943827
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540991}
  • Loading branch information
wangxianzhu authored and chromium-wpt-export-bot committed Mar 6, 2018
1 parent 88f08cc commit 2de9c6c
Showing 1 changed file with 52 additions and 0 deletions.
52 changes: 52 additions & 0 deletions css/css-tables/width-distribution/td-with-subpixel-padding.html
@@ -0,0 +1,52 @@
<!DOCTYPE html>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
div {
display: inline-block;
width: 20px;
height: 20px;
background: blue;
}
</style>
Passes if each row has two blue squares.
<table>
<tr>
<td class='target' style="padding: 0 0.8px"><div></div> <div></div></td>
<td style="padding: 0 0.8px; width: 30px"></td>
</tr>
</table>
<table>
<tr>
<td class='target' style="padding: 0 1px"><div></div> <div></div></td>
<td style="padding: 0 1px; width: 30px"></td>
</tr>
</table>
<table>
<tr>
<td class='target' style="padding: 0 1.3px"><div></div> <div></div></td>
<td style="padding: 0 1.3px; width: 30px"></td>
</tr>
</table>
<table>
<tr>
<td class='target' style="padding: 0 1.5px"><div></div> <div></div></td>
<td style="padding: 0 1.5px; width: 30px"></td>
</tr>
</table>
<table>
<tr>
<td class='target' style="padding: 0 1.7px"><div></div> <div></div></td>
<td style="padding: 0 1.7px; width: 30px"></td>
</tr>
</table>
<script>
test(() => {
var targets = document.getElementsByClassName('target');
for (var i = 0; i < targets.length; ++i) {
var divs = targets[i].getElementsByTagName('div');
assert_equals(divs.length, 2);
assert_equals(divs[0].offsetTop, divs[1].offsetTop, 'Contents of td.target[' + i + '] should not wrap');
}
});
</script>

0 comments on commit 2de9c6c

Please sign in to comment.