Skip to content

Commit

Permalink
cleanup WPT css-transitions timing-function parsing tests
Browse files Browse the repository at this point in the history
Move all such tests into parsing.
Eliminate duplicate tests and manual versions of automated tests.

Change-Id: I0ef507a1832c9ce113ed1a855653af7fd22bb0b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809508
Commit-Queue: George Steel <gtsteel@chromium.org>
Auto-Submit: George Steel <gtsteel@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699042}
  • Loading branch information
chromium-wpt-export-bot authored and foolip committed Sep 24, 2019
1 parent 7b9a8b1 commit 31bb563
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 338 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
<div id="target"></div>
<script>
test_computed_value("transition-timing-function", "linear");
test_computed_value("transition-timing-function", "", "ease");
test_computed_value("transition-timing-function", "initial", "ease");

test_computed_value("transition-timing-function", "ease");
test_computed_value("transition-timing-function", "ease-in");
Expand All @@ -22,7 +24,8 @@
test_computed_value("transition-timing-function", "cubic-bezier(0, -2, 1, 3)");
test_computed_value("transition-timing-function", "cubic-bezier(0, 0.7, 1, 1.3)");


test_computed_value("transition-timing-function", "step-start", "steps(1, start)");
test_computed_value("transition-timing-function", "step-end", "steps(1)");
test_computed_value("transition-timing-function", "steps(4, start)");
test_computed_value("transition-timing-function", "steps(2, end)", "steps(2)");
test_computed_value("transition-timing-function", "steps(2, jump-start)");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,23 @@
<script>
test_invalid_value("transition-timing-function", "auto");
test_invalid_value("transition-timing-function", "ease-in ease-out");

test_invalid_value("transition-timing-function", "cubic-bezier(foobar)");
test_invalid_value("transition-timing-function", "cubic-bezier(1, 2, 3)");
test_invalid_value("transition-timing-function", "cubic-bezier(1, 2, 3, infinite)");
test_invalid_value("transition-timing-function", "cubic-bezier(1, 2, 3, 4, 5)");
test_invalid_value("transition-timing-function", "cubic-bezier(-0.1, 0.1, 0.5, 0.9)");
test_invalid_value("transition-timing-function", "cubic-bezier(0.5, 0.1, 1.1, 0.9)");

test_invalid_value("transition-timing-function", "steps(foobar)");
test_invalid_value("transition-timing-function", "steps(3.3, end)");
test_invalid_value("transition-timing-function", "steps(3, top)");
test_invalid_value("transition-timing-function", "steps(-3, top)");
test_invalid_value("transition-timing-function", "steps(0, jump-start)");
test_invalid_value("transition-timing-function", "steps(0, jump-end)");
test_invalid_value("transition-timing-function", "steps(0, jump-both)");
test_invalid_value("transition-timing-function", "steps(1, jump-none)");

test_invalid_value("transition-timing-function", "initial, cubic-bezier(0, -2, 1, 3)");
test_invalid_value("transition-timing-function", "cubic-bezier(0, -2, 1, 3), initial");
</script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
test_valid_value("transition-timing-function", "cubic-bezier(0, -2, 1, 3)");
test_valid_value("transition-timing-function", "cubic-bezier(0, 0.7, 1, 1.3)");

test_valid_value("transition-timing-function", "step-start", "steps(1, start)");
test_valid_value("transition-timing-function", "step-end", "steps(1)");
test_valid_value("transition-timing-function", "steps(4)");
test_valid_value("transition-timing-function", "steps(4, start)");
test_valid_value("transition-timing-function", "steps(2, end)", "steps(2)");
test_valid_value("transition-timing-function", "steps(2, jump-start)");
Expand Down
94 changes: 0 additions & 94 deletions css/css-transitions/transition-timing-function-001.html

This file was deleted.

40 changes: 0 additions & 40 deletions css/css-transitions/transition-timing-function-007.html

This file was deleted.

40 changes: 0 additions & 40 deletions css/css-transitions/transition-timing-function-008.html

This file was deleted.

40 changes: 0 additions & 40 deletions css/css-transitions/transition-timing-function-009.html

This file was deleted.

41 changes: 0 additions & 41 deletions css/css-transitions/transition-timing-function-011.html

This file was deleted.

41 changes: 0 additions & 41 deletions css/css-transitions/transition-timing-function-012.html

This file was deleted.

41 changes: 0 additions & 41 deletions css/css-transitions/transition-timing-function-013.html

This file was deleted.

0 comments on commit 31bb563

Please sign in to comment.