Notify of appends to the right document when parsing into an already-…

…adopted node. nsContentSink used to decide that it was fine to not notify of silent appends to a document from the parser if the node was not on our document already. That's not ok, since if styling or layout have happened already on the document we're getting inserted into nobody notices them, which is wrong. Differential Revision: https://phabricator.services.mozilla.com/D25300 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1539742 gecko-commit: cf6cfe33476622c202fcbc34ef12f8ca1c039b8a gecko-integration-branch: central gecko-reviewers: bzbarsky
web-platform-tests · Apr 8, 2019 · 3a4ed45 · 3a4ed45
1 parent 81ae708
commit 3a4ed45
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 0 deletions.
diff --git a/xhtml/adopt-while-parsing-001-ref.html b/xhtml/adopt-while-parsing-001-ref.html
@@ -0,0 +1,9 @@
+<!doctype html>
+<title>Test reference</title>
+<style>
+  html, body { margin: 0 }
+</style>
+<iframe src="about:blank"></iframe>
+<div>
+  PASS
+</div>
diff --git a/xhtml/adopt-while-parsing-001.html b/xhtml/adopt-while-parsing-001.html
@@ -0,0 +1,19 @@
+<!doctype html>
+<title>Appending from the parser after adopting in an XML document doesn't miss notifications</title>
+<link rel="match" href="adopt-while-parsing-001-ref.html">
+<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1511329">
+<link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io">
+<link rel="author" title="Mozilla" href="https://mozilla.org">
+<style>
+  html, body { margin: 0 }
+</style>
+<script>
+  // If we don't get notified of the <div> insertion, the PASS text will never appear.
+  function parsingInterrupted() {
+    let frameDoc = document.querySelector("iframe").contentDocument;
+    let root = frameDoc.documentElement;
+    document.documentElement.appendChild(root);
+    root.offsetTop;
+  }
+</script>
+<iframe src="adopt-while-parsing.xhtml"></iframe>
diff --git a/xhtml/adopt-while-parsing.xhtml b/xhtml/adopt-while-parsing.xhtml
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+<body>
+  <script>
+    window.parent.parsingInterrupted();
+  </script>
+  <div>
+    PASS
+  </div>
+</body>
+</html>