Skip to content

Commit

Permalink
[Longtasks] Ship the buffered flag
Browse files Browse the repository at this point in the history
This change ships the buffered flag, moving some work to WindowPerformance to
allow unsubscribing when the buffer becomes full and there are no observers.
Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/cX5ahS7nCFw

Bug: 1016815
Change-Id: I3c20c65ed921d4a939d2214b25d3c7154129adda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956075
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723906}
  • Loading branch information
npm1 authored and chromium-wpt-export-bot committed Dec 11, 2019
1 parent d09c77a commit 3acfa44
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion longtask-timing/buffered-flag.window.js
Expand Up @@ -8,7 +8,7 @@ async_test(t => {
return;
assert_equals(entry.entryType, 'longtask');
assert_equals(entry.name, 'self');
assert_greater_than(longtask.duration, 50);
assert_greater_than(entry.duration, 50);
longtaskObserved = true;
});
assert_true(longtaskObserved, 'Did not observe buffered longtask.');
Expand Down

0 comments on commit 3acfa44

Please sign in to comment.