Skip to content

Commit

Permalink
nit: better naming of things (#9702)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcoscaceres committed Mar 7, 2018
1 parent e3b6514 commit 44442a7
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -139,7 +139,7 @@
});

// PaymentDetailsInit
const validDetails = Object.freeze({
const failDetails = Object.freeze({
displayItems: failPaymentItems,
id: "this cannot be changed",
modifiers: failModifiers,
Expand All @@ -156,7 +156,7 @@

function smokeTest() {
promise_test(async t => {
const request = new PaymentRequest(validMethods, validDetails);
const request = new PaymentRequest(validMethods, failDetails);
await promise_rejects(
t,
new TypeError(),
Expand All @@ -178,7 +178,7 @@
const testAssertion = buttonElement.textContent.trim();
buttonElement.disabled = true;
promise_test(async t => {
const request = new PaymentRequest(validMethods, validDetails, options);
const request = new PaymentRequest(validMethods, failDetails, options);
const detailsPromise = Promise.resolve(details);
const acceptPromise = request.show(detailsPromise);
assert_equals(request.id, "this cant be changed", "id must never change.");
Expand Down

0 comments on commit 44442a7

Please sign in to comment.