Skip to content

Commit

Permalink
Force other forced color properties at used value time
Browse files Browse the repository at this point in the history
Forced colors should now happen at used value time. This change adjusts
the used value of text-decoration-color, -internal-visited-text-
decoration-color, column-rule-color, -internal-visited-column-rule-color,
-webkit-tap-highlight-color, -webkit-text-emphasis-color, and -internal-
visited-text-emphasis-color to take forced colors into account. No
internal properties were needed since we only ever force these set of
properties to currentColor in forced colors mode.

The only remaining property to move to used value time is 'color'.

Bug: 970285
Change-Id: Ica77609ce631f1768bdd52753535a484a32d3a3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523664
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829973}
  • Loading branch information
alisonmaher authored and chromium-wpt-export-bot committed Nov 21, 2020
1 parent cb32b4d commit 451877b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 47 deletions.
24 changes: 0 additions & 24 deletions forced-colors-mode/forced-colors-mode-04.html

This file was deleted.

22 changes: 0 additions & 22 deletions forced-colors-mode/forced-colors-mode-32.html

This file was deleted.

10 changes: 9 additions & 1 deletion forced-colors-mode/forced-colors-mode-40.html
Expand Up @@ -10,9 +10,13 @@
div {
background-color: green;
border-color: green;
column-rule-color: green;
fill: green;
outline-color: green;
stroke: green;
text-decoration-color: green;
-webkit-tap-highlight-color: green;
-webkit-text-emphasis-color: green;
}
</style>
<div id="div">
Expand All @@ -26,9 +30,13 @@
"border-left-color",
"border-right-color",
"border-top-color",
"column-rule-color",
"fill",
"outline-color",
"stroke"
"stroke",
"text-decoration-color",
"-webkit-tap-highlight-color",
"-webkit-text-emphasis-color"
];
for (let property of properties_to_test) {
test(function() {
Expand Down

0 comments on commit 451877b

Please sign in to comment.