Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prior to this change, effects are always given the current phase of the timeline associated with them. This fails in certain situations such as pausing and then scrolling, setting current time with an inactive timeline, and many other scenarios where hold_time is set. In order to fix this, we have introduced hold_phase. Anytime hold_time is updated, hold_phase will also be updated with the appropriate phase. Sometimes the phase is set explicitly and other times we pull from the timeline current time. Animation effects will be given the animation hold_phase if it is populated, otherwise it will calculate its current phase (similar to how current time is calculated). The WebAnimations spec is being updated to reflect this change. Bug: 1046833 Change-Id: I4bf1e42eaab684c18829a79acc1ab8911ec893af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135336 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#797835}
- Loading branch information
1 parent
fdfb0a5
commit 4d71665
Showing
1 changed file
with
163 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters