[LayoutNG] Set column fragments to the actual column size.

Just letting the fragmentation machinery do what it would do if it gets to treat column boxes as regular column content was no conscious choice, and it turns out that setting the column fragments to the actual column size is better, or we get some trouble with overflow, both when it comes to painting column rules, and the fact that we get spurious empty column fragments after unbreakable content (new unit test NGColumnLayoutAlgorithmTest.TallReplacedContent). Remove fast/multicol/rule-in-nested-with-too-tall-line.html and replace it with a valid test (that still fails both in legacy and NG; in NG because we fail to paint text on a general basis). Bug: 829028 Change-Id: I3656c299c7a87bea29e1790477cf524b9522fa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948923 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#721376}
web-platform-tests · Dec 4, 2019 · 54a6679 · 54a6679
1 parent 3f1485c
commit 54a6679
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 0 deletions.
diff --git a/css/css-multicol/fixed-size-child-with-overflow.html b/css/css-multicol/fixed-size-child-with-overflow.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
+<link rel="help" href="https://www.w3.org/TR/css-multicol-1/#column-gaps-and-rules">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="columns:4; column-fill:auto; column-gap:5px; column-rule:5px solid green; width:100px; height:100px; background:red;">
+  <div style="height:50px;">
+    <div style="height:400px; background:green;"></div>
+  </div>
+</div>
diff --git a/css/css-multicol/nested-with-too-tall-line-ref.html b/css/css-multicol/nested-with-too-tall-line-ref.html
@@ -0,0 +1,6 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
+<p>The word "PASS" should be seen below, and there should be no red.</p>
+<div style="line-height:200px;">
+  PASS
+</div>
diff --git a/css/css-multicol/nested-with-too-tall-line.html b/css/css-multicol/nested-with-too-tall-line.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
+<link rel="help" href="https://www.w3.org/TR/css-multicol-1/#the-multi-column-model">
+<link rel="help" href="https://drafts.csswg.org/css-break/#unforced-breaks">
+<link rel="match" href="nested-with-too-tall-line-ref.html">
+<style>
+    .multicol { columns:2; column-fill:auto; }
+</style>
+<p>The word "PASS" should be seen below, and there should be no red.</p>
+<div class="multicol" style="width:100px; height:100px; line-height:200px;">
+    <div class="multicol" style="height:200px; column-rule:solid red;">
+        PASS
+    </div>
+</div>