Skip to content

Commit

Permalink
Add more log formatter for --verbose option
Browse files Browse the repository at this point in the history
Make `--verbose` supports the raw and tbpl log formatters for
the alias of `--log-*-level` option.
  • Loading branch information
qiuzhong committed Dec 29, 2018
1 parent 8d8aeb1 commit 5caeb87
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 7 deletions.
44 changes: 40 additions & 4 deletions tools/wpt/tests/test_run.py
Expand Up @@ -72,20 +72,56 @@ def test_setup_wptrunner(venv, logger, product):
run.setup_wptrunner(venv, **kwargs)


def test_opt_verbose():
def test_opt_mach_verbose():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--verbose chrome".split()))
kwargs = vars(parser.parse_args("--log-mach - --verbose chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_mach_level"] == "debug"

def test_opt_verbose_log_mach_level_debug():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--verbose --log-mach-level debug chrome".split()))
kwargs = vars(parser.parse_args("--log-mach - --verbose --log-mach-level debug chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_mach_level"] == "debug"

def test_opt_verbose_log_mach_level_info():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--verbose --log-mach-level info chrome".split()))
kwargs = vars(parser.parse_args("--log-mach - --verbose --log-mach-level info chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_mach_level"] == "info"

def test_opt_raw_verbose():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--log-raw - --verbose chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_raw_level"] == "debug"

def test_opt_verbose_log_raw_level_debug():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--log-raw - --verbose --log-raw-level debug chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_raw_level"] == "debug"

def test_opt_verbose_log_raw_level_info():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--log-raw - --verbose --log-raw-level info chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_raw_level"] == "info"

def test_opt_tbpl_verbose():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--log-tbpl - --verbose chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_tbpl_level"] == "debug"

def test_opt_verbose_log_tbpl_level_debug():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--log-tbpl - --verbose --log-tbpl-level debug chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_tbpl_level"] == "debug"

def test_opt_verbose_log_tbpl_level_info():
parser = run.create_parser()
kwargs = vars(parser.parse_args("--log-tbpl - --verbose --log-tbpl-level info chrome".split()))
wptcommandline.check_verbose(kwargs)
assert kwargs["log_tbpl_level"] == "info"
2 changes: 1 addition & 1 deletion tools/wpt/wpt.py
Expand Up @@ -9,7 +9,6 @@
from six import iteritems
from . import virtualenv

from wptrunner import wptcommandline

here = os.path.dirname(__file__)
wpt_root = os.path.abspath(os.path.join(here, os.pardir, os.pardir))
Expand Down Expand Up @@ -125,6 +124,7 @@ def main(prog=None, argv=None):
else:
args = extras

from wptrunner import wptcommandline
wptcommandline.check_verbose(kwargs)

if script:
Expand Down
6 changes: 4 additions & 2 deletions tools/wptrunner/wptrunner/wptcommandline.py
Expand Up @@ -529,8 +529,10 @@ def check_args(kwargs):

def check_verbose(kwargs):
if kwargs.get("verbose"):
if not kwargs.get("log_mach_level"):
kwargs["log_mach_level"] = "debug"
for key, value in kwargs.items():
if key.startswith("log_") and not key.endswith("_level"):
if kwargs.get(key):
kwargs[key + "_level"] = "debug"

def check_args_update(kwargs):
set_from_config(kwargs)
Expand Down

0 comments on commit 5caeb87

Please sign in to comment.