Skip to content

Commit

Permalink
[LayoutNG] Don't allow line height quirk inside list items.
Browse files Browse the repository at this point in the history
This makes us match legacy engine behavior more closely, and both Edge
and Firefox have something similar, although Firefox triggers based on
element type (LI), and not display type (list-item). There's currently
nothing in the spec [1] that suggests such special behavior for list
items.

[1] https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk

This fix makes the line height differences go away in the test
tables/mozilla/bugs/bug23235.html (but note that it will still require
a rebaseline, because of minor text rendering differences between
legacy and NG).

See whatwg/quirks#38 for spec discussion.

Change-Id: I396c0c85454feeaa45a0a5953b9e6b7c475d131e
Reviewed-on: https://chromium-review.googlesource.com/c/1379897
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618304}
  • Loading branch information
mstensho authored and chromium-wpt-export-bot committed Dec 20, 2018
1 parent dfa78e2 commit 66d1667
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
12 changes: 12 additions & 0 deletions quirks/line-height-in-list-item.tentative.html
@@ -0,0 +1,12 @@
<!-- quirks mode -->
<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
<link rel="help" href="https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk">
<link rel="match" href="reference/green-100px-square-no-red.html">
<meta name="assert" content="List items force strict line height; see https://github.com/whatwg/quirks/issues/38">
<p>There should be a filled green square below, and no red.</p>
<div style="width:100px; height:100px; background:red;">
<li style="line-height:50px; color:green; background:green;">
<br>
<div style="display:inline-block; width:1px; height:1px;"></div>
</li>
</div>
4 changes: 4 additions & 0 deletions quirks/reference/green-100px-square-no-red.html
@@ -0,0 +1,4 @@
<!-- quirks mode -->
<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
<p>There should be a filled green square below, and no red.</p>
<div style="width:100px; height:100px; background:green;"></div>

0 comments on commit 66d1667

Please sign in to comment.