Skip to content

Commit

Permalink
webrtc wpt: add addIceCandidate(new RTCIceCandidate({candidate, sdpMi…
Browse files Browse the repository at this point in the history
…d})) test

which should have caught the bug

BUG=965483

Change-Id: I379f14ee625a9f43889d778b9774bb04949c73af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628722
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#663512}
  • Loading branch information
fippo authored and chromium-wpt-export-bot committed May 27, 2019
1 parent 36f2a92 commit 740915b
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions webrtc/RTCPeerConnection-addIceCandidate.html
Expand Up @@ -263,6 +263,17 @@
sdpMid: sdpMid1 }));
}, 'Add candidate with only valid sdpMid should succeed');

promise_test(t => {
const pc = new RTCPeerConnection();

t.add_cleanup(() => pc.close());

return pc.setRemoteDescription(sessionDesc)
.then(() => pc.addIceCandidate(new RTCIceCandidate({
candidate: candidateStr1,
sdpMid: sdpMid1 })));
}, 'Add candidate with only valid sdpMid and RTCIceCandidate should succeed');

promise_test(t => {
const pc = new RTCPeerConnection();

Expand Down

0 comments on commit 740915b

Please sign in to comment.