Skip to content

Commit

Permalink
[layout] Fix OOF replaced elements with display: table.
Browse files Browse the repository at this point in the history
Previously we had special logic within ng_absolute_utils.cc which simply
checked if we had an element with display:table for some table specific
logic.

This was incorrect, and should have been checking for the LayoutObject
type instead.
This caused some incorrect layout of replaced elements when OOF.

This patch uses the NGBlockNode::IsTable instead to apply this logic.

Bug: 1138851
Change-Id: Id428df4f48c48ad949bd3d8ffce70827e8809081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483962
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818448}
  • Loading branch information
bfgeek authored and chromium-wpt-export-bot committed Oct 19, 2020
1 parent 6c6f4de commit 7549876
Showing 1 changed file with 7 additions and 0 deletions.
@@ -0,0 +1,7 @@
<!DOCTYPE html>
<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1138851">
<p>Test passes if there is a filled green square.</p>
<div style="position: relative;">
<canvas width="200" style="background: green; width: 100px; height: 100px; position: absolute; display: table;"></canvas>
</div>

0 comments on commit 7549876

Please sign in to comment.