Skip to content

Commit

Permalink
[web-animation] Make contain/will-change/writing modes props not anim…
Browse files Browse the repository at this point in the history
…atable

Match the recent CSSWG resolutions:
w3c/csswg-drafts#2737 (comment)
w3c/csswg-drafts#2751 (comment)

Make following properties none animatable:

* contain
* direction
* display
* text-orientation
* unicode-bidi
* will-change
* writing-mode

Note that wpt tests have already been updated for direction and writing-mode
here [1]

[1] 41f4ab6

Bug: 860359
Change-Id: I3e7296e3c28ff494eddbc6f011621dd29ba7d2aa
Reviewed-on: https://chromium-review.googlesource.com/1127062
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573509}
  • Loading branch information
majido authored and chromium-wpt-export-bot committed Jul 9, 2018
1 parent d59ad16 commit 7f017e8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 26 deletions.
24 changes: 0 additions & 24 deletions web-animations/animation-model/animation-types/property-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -413,12 +413,6 @@ const gCSSProperties = {
{ type: 'discrete', options: [ [ 'auto', '1px' ] ] }
]
},
'contain': {
// https://drafts.csswg.org/css-containment/#propdef-contain
types: [
{ type: 'discrete', options: [ [ 'strict', 'none' ] ] }
]
},
'content': {
// https://drafts.csswg.org/css-content-3/#propdef-content
types: [
Expand Down Expand Up @@ -1334,12 +1328,6 @@ const gCSSProperties = {
types: [
]
},
'text-orientation': {
// https://drafts.csswg.org/css-writing-modes-3/#propdef-text-orientation
types: [
{ type: 'discrete', options: [ [ 'upright', 'sideways' ] ] }
]
},
'text-overflow': {
// https://drafts.csswg.org/css-ui/#propdef-text-overflow
types: [
Expand Down Expand Up @@ -1418,12 +1406,6 @@ const gCSSProperties = {
// https://drafts.csswg.org/css-transforms-2/#individual-transforms
types: [ 'scaleList' ]
},
'unicode-bidi': {
// https://drafts.csswg.org/css-writing-modes-3/#propdef-unicode-bidi
types: [
{ type: 'discrete', options: [ [ 'embed', 'bidi-override' ] ] },
]
},
'vector-effect': {
// https://svgwg.org/svg2-draft/coords.html#VectorEffectProperty
types: [
Expand Down Expand Up @@ -1460,12 +1442,6 @@ const gCSSProperties = {
// https://drafts.csswg.org/css-text-3/#propdef-word-spacing
types: [ 'lengthPercentageOrCalc' ]
},
'will-change': {
// http://dev.w3.org/csswg/css-will-change/#propdef-will-change
types: [
{ type: 'discrete', options: [ [ 'scroll-position', 'contents' ] ] }
]
},
'z-index': {
// https://drafts.csswg.org/css-position/#propdef-z-index
types: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,16 @@
'transitionDuration',
'transitionProperty',
'transitionTimingFunction',
'display',
'contain',
'direction',
'unsupportedProperty',
'display',
'textOrientation',
'unicodeBidi',
'willChange',
'writingMode',

'unsupportedProperty',

'font-size', // Supported property that uses dashes
];

Expand Down

0 comments on commit 7f017e8

Please sign in to comment.