Skip to content

Commit

Permalink
Loosen assumptions so actual implementations match them (#11677)
Browse files Browse the repository at this point in the history
  • Loading branch information
gsnedders committed Jun 27, 2018
1 parent 8780e84 commit 865d9b4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
9 changes: 7 additions & 2 deletions docs/_writing-tests/assumptions.md
Expand Up @@ -16,8 +16,13 @@ tests can freely rely on these assumptions being true:
* The user stylesheet is empty (except where indicated by the tests).
* The device is interactive and uses scroll bars.
* The device has the Ahem font installed.
* The HTML `div` element is assigned `display: block;` and no other
property declaration.
* The HTML `div` element is assigned `display: block;`, the
`unicode-bidi` property may be declared, and no other property
declarations.
<!-- unicode-bidi: isolate should be required; we currently don't
assume this because Chrome and Safari are yet to ship this: see
https://bugs.chromium.org/p/chromium/issues/detail?id=296863 and
https://bugs.webkit.org/show_bug.cgi?id=65617 -->
* The HTML `span` element is assigned `display: inline;` and no other
property declaration.
* The HTML `p` element is assigned `display: block;`
Expand Down
4 changes: 3 additions & 1 deletion infrastructure/assumptions/html-elements.html
Expand Up @@ -67,7 +67,9 @@
for (var i = 0; i < a_styles.length; i++) {
var property = a_styles[i];
assert_equals(property, b_styles[i], "Same property on div.a and div.b");
assert_equals(a_styles[property], b_styles[property], "Different value for " + property);
if (property !== "unicode-bidi") {
assert_equals(a_styles[property], b_styles[property], "Different value for " + property);
}
}
}, "Compare CSS div definitions (only valid if pre-reqs pass)");

Expand Down

This file was deleted.

0 comments on commit 865d9b4

Please sign in to comment.