Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update navigator.ink.requestPresenter() to use a dictionary param
requestPresenter took in two params, a String |type| and an Element |presentationArea|. The goal of the |type| param was to enable requestPresenter() to be easily extensible in the future for other types of presenters. However, in its current state, it is a no-op param. For this reason, after some discussion ([1], [2], [3]) it has been decided that the API should be updated to instead just use a dictionary param. This will still be easily extensible in the future, but won't require a string param until then. [1]: WICG/ink-enhancement#20 [2]: w3ctag/design-reviews#473 (comment) [3]: https://groups.google.com/a/chromium.org/g/blink-dev/c/ZtqwKR_HIAE Bug: 1052145 Change-Id: I9ef18a04ab150fff8c8f173bfa209e10d90781f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3027884 Reviewed-by: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#902434}
- Loading branch information
1 parent
4331522
commit 94a6599
Showing
4 changed files
with
19 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
delegated-ink/exception-thrown-untrusted-event.tentative.window.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters