Skip to content

Commit

Permalink
[WebXR] Change from XRPresentationFrame to XRFrame
Browse files Browse the repository at this point in the history
XRFrame is a more generric name because with the addition of the input API
we're using frames in places where there's no expectation of rendering or
presentation involved[1].

[1] immersive-web/webxr#364

Bug: 852528
Change-Id: Ie9a325cd626912b09bb2b77fe1b46d29baaef0b8
Reviewed-on: https://chromium-review.googlesource.com/1103426
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568654}
  • Loading branch information
codeimpl authored and chromium-wpt-export-bot committed Jun 20, 2018
1 parent 8d7269f commit 9589fb2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions interfaces/webxr.idl
Expand Up @@ -47,9 +47,9 @@ dictionary XRSessionCreationOptions {
attribute EventHandler onend;
};

callback XRFrameRequestCallback = void (DOMHighResTimeStamp time, XRPresentationFrame frame);
callback XRFrameRequestCallback = void (DOMHighResTimeStamp time, XRFrame frame);

[SecureContext, Exposed=Window] interface XRPresentationFrame {
[SecureContext, Exposed=Window] interface XRFrame {
readonly attribute FrozenArray<XRView> views;

XRDevicePose? getDevicePose(XRCoordinateSystem coordinateSystem);
Expand Down
2 changes: 1 addition & 1 deletion webxr/resources/webxr_util.js
Expand Up @@ -12,7 +12,7 @@ function forEachWebxrObject(callback) {
callback(window.XRSessionCreationOptions, 'XRSessionCreationOptions');
callback(window.XRFrameRequestCallback, 'XRFrameRequestCallback');
callback(window.XRPresentationContext, 'XRPresentationContext');
callback(window.XRPresentationFrame, 'XRPresentationFrame');
callback(window.XRFrame, 'XRFrame');
callback(window.XRView, 'XRView');
callback(window.XRViewport, 'XRViewport');
callback(window.XRDevicePose, 'XRDevicePose');
Expand Down

0 comments on commit 9589fb2

Please sign in to comment.