Skip to content

Commit

Permalink
Disable real time reporting APIs for mode A/B traffic.
Browse files Browse the repository at this point in the history
Also,
1. Added browser test for that.
2. Removed checking kRealTimeReporting flag in navigator_auction.cc when
  handling rtr fields, since these IDL fields are marked RunTimeEnabled,
  and these fields will just not show up when the flag is disabled.
3. Modify WPT expectations.

Bug: 337132755

Change-Id: I61f5c0ebb96c2177574dc02fd90d7269b00f407c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539632
Commit-Queue: Qingxin Wu <qingxinwu@google.com>
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1305132}
  • Loading branch information
Qingxin Wu authored and chromium-wpt-export-bot committed May 23, 2024
1 parent 2d2b35a commit a134a28
Showing 1 changed file with 54 additions and 54 deletions.
108 changes: 54 additions & 54 deletions fledge/tentative/auction-config.https.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,60 @@ makeTest({
auctionConfigOverrides: {deprecatedRenderURLReplacements: {'%%No_End_Percents': 'SSP'}}
});

makeTest({
name: 'sellerRealTimeReportingConfig has default local reporting type',
expect: EXPECT_WINNER,
auctionConfigOverrides: {sellerRealTimeReportingConfig:
{type: 'default-local-reporting'}}
});

makeTest({
name: 'sellerRealTimeReportingConfig has no type',
expect: EXPECT_EXCEPTION(TypeError),
auctionConfigOverrides: {sellerRealTimeReportingConfig:
{notType: 'default-local-reporting'}}
});

makeTest({
name: 'sellerRealTimeReportingConfig has unknown type',
expect: EXPECT_WINNER,
auctionConfigOverrides: {sellerRealTimeReportingConfig: {type: 'unknown type'}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig',
expect: EXPECT_WINNER,
auctionConfigOverrides: {perBuyerRealTimeReportingConfig:
{'https://example.com': {type: 'default-local-reporting'}}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig has invalid buyer',
expect: EXPECT_EXCEPTION(TypeError),
auctionConfigOverrides: {perBuyerRealTimeReportingConfig:
{'http://example.com': {type: 'default-local-reporting'}}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig has no type',
expect: EXPECT_EXCEPTION(TypeError),
auctionConfigOverrides: {perBuyerRealTimeReportingConfig:
{'https://example.com': {notType: 'default-local-reporting'}}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig has unknown type',
expect: EXPECT_WINNER,
auctionConfigOverrides: {perBuyerRealTimeReportingConfig:
{'https://example.com': {type: 'unknown type'}}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig has no entry',
expect: EXPECT_WINNER,
auctionConfigOverrides: {perBuyerRealTimeReportingConfig: {}}
});

makeTest({
name: 'no buyers => no winners',
expect: EXPECT_NO_WINNER,
Expand Down Expand Up @@ -507,60 +561,6 @@ makeTest({
{width: '200furlongs', height: '200'}]}
});

makeTest({
name: 'sellerRealTimeReportingConfig has default local reporting type',
expect: EXPECT_WINNER,
auctionConfigOverrides: {sellerRealTimeReportingConfig:
{type: 'default-local-reporting'}}
});

makeTest({
name: 'sellerRealTimeReportingConfig has no type',
expect: EXPECT_EXCEPTION(TypeError),
auctionConfigOverrides: {sellerRealTimeReportingConfig:
{notType: 'default-local-reporting'}}
});

makeTest({
name: 'sellerRealTimeReportingConfig has unknown type',
expect: EXPECT_WINNER,
auctionConfigOverrides: {sellerRealTimeReportingConfig: {type: 'unknown type'}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig',
expect: EXPECT_WINNER,
auctionConfigOverrides: {perBuyerRealTimeReportingConfig:
{"https://example.com": {type: 'default-local-reporting'}}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig has no entry',
expect: EXPECT_WINNER,
auctionConfigOverrides: {perBuyerRealTimeReportingConfig: {}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig has invalid buyer',
expect: EXPECT_EXCEPTION(TypeError),
auctionConfigOverrides: {perBuyerRealTimeReportingConfig:
{"http://example.com": {type: 'default-local-reporting'}}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig has no type',
expect: EXPECT_EXCEPTION(TypeError),
auctionConfigOverrides: {perBuyerRealTimeReportingConfig:
{"https://example.com": {notType: 'default-local-reporting'}}}
});

makeTest({
name: 'perBuyerRealTimeReportingConfig has unknown type',
expect: EXPECT_WINNER,
auctionConfigOverrides: {perBuyerRealTimeReportingConfig:
{"https://example.com": {type: 'unknown type'}}}
});

subsetTest(promise_test, async test => {
const uuid = generateUuid(test);

Expand Down

0 comments on commit a134a28

Please sign in to comment.