Skip to content

Commit

Permalink
Fix a DCHECK if a block was seen in font-feature-settings.
Browse files Browse the repository at this point in the history
We cannot Consume() in the streaming parser without first checking that
there's no block involved.

Fixed: 341349803
Change-Id: I0740fe7359f056a561dd1a82f1355b999537945a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554250
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304312}
  • Loading branch information
Steinar H. Gunderson authored and chromium-wpt-export-bot committed May 22, 2024
1 parent 16e779d commit affa7c3
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions css/css-fonts/variable-in-feature-crash.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html>
<head>
<title>CSS value parser: Crash with blocks in font-feature-settings</title>
<link rel="help" href="https://crbug.com/341349803">
<style>#a{font-feature-settings:var(--foo)}</style>
</head>
<body>
<p>Test passes if it does not crash.</p>
</body>
</html>

0 comments on commit affa7c3

Please sign in to comment.