Skip to content

Commit

Permalink
Fix RTCRtpReceiver-getContributingSources.https.html flake.
Browse files Browse the repository at this point in the history
The flake was
"Failed to execute 'addTrack' on 'RTCPeerConnection': The
RTCPeerConnection's signalingState is 'closed'."

The promise_test could be torn down and execute
t.add_cleanup(() => pc1.close());
before connectAndExpectNoCsrcs() was ready due to not using "await" when
calling the test helper method.

TBR=hta@chromium.org
NOTRY=True

// See #14791

Bug: None
Change-Id: I1dac26837b3f29b8f1c38709c7a8488d0e2580c7
Reviewed-on: https://chromium-review.googlesource.com/c/1424891
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624622}
  • Loading branch information
henbos authored and chromium-wpt-export-bot committed Jan 21, 2019
1 parent 821b438 commit b69756a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions webrtc/RTCRtpReceiver-getContributingSources.https.html
Expand Up @@ -26,10 +26,10 @@
}

promise_test(async t => {
connectAndExpectNoCsrcs(t, 'audio');
await connectAndExpectNoCsrcs(t, 'audio');
}, '[audio] getContributingSources() returns an empty list in loopback call');

promise_test(async t => {
connectAndExpectNoCsrcs(t, 'video');
await connectAndExpectNoCsrcs(t, 'video');
}, '[video] getContributingSources() returns an empty list in loopback call');
</script>

0 comments on commit b69756a

Please sign in to comment.