Skip to content

Commit

Permalink
[wasm] Enable and fix wasm exceptions WPTs
Browse files Browse the repository at this point in the history
For most tests, expectations were deleted since the tests now pass.

The getArg test was corrected to match the spec:
https://webassembly.github.io/exception-handling/js-api/index.html#dom-exception-getarg

The tag type test had its expectations updated, but is still
(incorrectly) failing because the test also depends on the not-yet-shipped
type reflection proposal. Updated the spec bug to bring this conversation
back to the spec (WebAssembly/exception-handling#172).

Bug: v8:11992
Change-Id: I979a9eb00219e0b9515d43bbeff6f80ac57df7c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3972061
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1063368}
  • Loading branch information
ajklein authored and chromium-wpt-export-bot committed Oct 25, 2022
1 parent cc11041 commit b8516ab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion wasm/jsapi/exception/getArg.tentative.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test(() => {
test(() => {
const tag = new WebAssembly.Tag({ parameters: [] });
const exn = new WebAssembly.Exception(tag, []);
assert_throws_js(TypeError, () => exn.getArg(tag, 1));
assert_throws_js(RangeError, () => exn.getArg(tag, 1));
}, "Index out of bounds");

test(() => {
Expand Down

0 comments on commit b8516ab

Please sign in to comment.