Skip to content

Commit

Permalink
[wpt] Fix break-request tests.
Browse files Browse the repository at this point in the history 
These tests were presumably written when the flex spec said something
along the lines of:
"when a forced break (via. page-break-before/page-break-after) is
 encounted, create a new flex-line".

The spec in this state was overloading the fragmentation properties to
control breaking of flex-lines, and was subsequently updated to refer
to forced breaks when fragmentation was invovled.

These tests don't have any fragmentation involved, and are asserting
incorrect behaviour that breaks should be inserted.

(There is an argument that an additional property/properties should be
 introduced to allow for this - but that is a separate issue).

Updated tests to assert to behaviour change in the presence of
page-break-before/page-break-after.

Change-Id: Id3575b5b17173681600ed63cd40c8bb87281113b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3813703
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032644}
  • Loading branch information
@bfgeek @chromium-wpt-export-bot
bfgeek authored and chromium-wpt-export-bot committed Aug 8, 2022
1 parent 4e37177 commit b91acab
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
12 changes: 6 additions & 6 deletions css/css-flexbox/flexbox-break-request-horiz-001-ref.html
View file
Expand Up @@ -56,16 +56,16 @@
<div class="item fullCrossSize" style="float: left"></div>
</div>
<div class="flexbox">
<div class="item halfCrossSize"></div>
<div class="item halfCrossSize"></div>
<div class="item fullCrossSize" style="float: left"></div>
<div class="item fullCrossSize" style="float: left"></div>
</div>
<div class="flexbox">
<div class="item halfCrossSize"></div>
<div class="item halfCrossSize"></div>
<div class="item fullCrossSize" style="float: left"></div>
<div class="item fullCrossSize" style="float: left"></div>
</div>
<div class="flexbox">
<div class="item halfCrossSize"></div>
<div class="item halfCrossSize"></div>
<div class="item fullCrossSize" style="float: left"></div>
<div class="item fullCrossSize" style="float: left"></div>
</div>
<div style="clear: both"></div>

Expand Down
2 changes: 1 addition & 1 deletion css/css-flexbox/flexbox-break-request-horiz-001a.html
View file
Expand Up @@ -7,7 +7,7 @@
<head>
<title>CSS Test: Testing page-break-before in horizontal multi-line flex containers</title>
<link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com">
<link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#algo-line-break">
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#change-201409-algo-breaks">
<link rel="match" href="flexbox-break-request-horiz-001-ref.html">
<meta charset="utf-8">
<style>
Expand Down
2 changes: 1 addition & 1 deletion css/css-flexbox/flexbox-break-request-horiz-001b.html
View file
Expand Up @@ -7,7 +7,7 @@
<head>
<title>CSS Test: Testing page-break-after in horizontal multi-line flex containers</title>
<link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com">
<link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#algo-line-break">
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#change-201409-algo-breaks">
<link rel="match" href="flexbox-break-request-horiz-001-ref.html">
<meta charset="utf-8">
<style>
Expand Down
12 changes: 6 additions & 6 deletions css/css-flexbox/flexbox-break-request-vert-001-ref.html
View file
Expand Up @@ -56,16 +56,16 @@
<div class="item fullCrossSize"></div>
</div>
<div class="flexbox">
<div class="item halfCrossSize" style="float: left"></div>
<div class="item halfCrossSize" style="float: left"></div>
<div class="item fullCrossSize"></div>
<div class="item fullCrossSize"></div>
</div>
<div class="flexbox">
<div class="item halfCrossSize" style="float: left"></div>
<div class="item halfCrossSize" style="float: left"></div>
<div class="item fullCrossSize"></div>
<div class="item fullCrossSize"></div>
</div>
<div class="flexbox">
<div class="item halfCrossSize" style="float: left"></div>
<div class="item halfCrossSize" style="float: left"></div>
<div class="item fullCrossSize"></div>
<div class="item fullCrossSize"></div>
</div>
<div style="clear: both"></div>

Expand Down
2 changes: 1 addition & 1 deletion css/css-flexbox/flexbox-break-request-vert-001a.html
View file
Expand Up @@ -7,7 +7,7 @@
<head>
<title>CSS Test: Testing page-break-before in vertical multi-line flex containers</title>
<link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com">
<link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#algo-line-break">
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#change-201409-algo-breaks">
<link rel="match" href="flexbox-break-request-vert-001-ref.html">
<meta charset="utf-8">
<style>
Expand Down
2 changes: 1 addition & 1 deletion css/css-flexbox/flexbox-break-request-vert-001b.html
View file
Expand Up @@ -7,7 +7,7 @@
<head>
<title>CSS Test: Testing page-break-after in vertical multi-line flex containers</title>
<link rel="author" title="Daniel Holbert" href="mailto:dholbert@mozilla.com">
<link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#algo-line-break">
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#change-201409-algo-breaks">
<link rel="match" href="flexbox-break-request-vert-001-ref.html">
<meta charset="utf-8">
<style>
Expand Down

0 comments on commit b91acab

Please sign in to comment.