Skip to content

Commit

Permalink
VT: Rename domUpdated to updateCallbackDone
Browse files Browse the repository at this point in the history
This patch renames the promise as a result of the following resolution:
w3c/csswg-drafts#8144

R=khushalsagar@chromium.org, bokan@chromium.org

Change-Id: Ic0d4f3af2569462ccbf7e30fe258f0e52b21286e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4178008
Auto-Submit: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1094162}
  • Loading branch information
vmpstr authored and chromium-wpt-export-bot committed Jan 19, 2023
1 parent 978487b commit ba9de5e
Show file tree
Hide file tree
Showing 10 changed files with 24 additions and 24 deletions.
10 changes: 5 additions & 5 deletions css/css-view-transitions/duplicate-tag-rejects-capture.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@
transition.ready.then(reject, () => {readyRejected = true;});

// The domUpdate promise resolves (since there is no callback).
let domUpdatedResolved = false;
transition.domUpdated.then(() => {
assert_true(readyRejected, "ready not rejected before domUpdated");
domUpdatedResolved = true;
let updateCallbackDoneResolved = false;
transition.updateCallbackDone.then(() => {
assert_true(readyRejected, "ready not rejected before updateCallbackDone");
updateCallbackDoneResolved = true;
}, reject);

// Finally finish resolves.
transition.finished.then(() => {
assert_true(domUpdatedResolved, "domUpdated not resolved before finish");
assert_true(updateCallbackDoneResolved, "updateCallbackDone not resolved before finish");
resolve();
}, reject);
});
Expand Down
12 changes: 6 additions & 6 deletions css/css-view-transitions/duplicate-tag-rejects-start.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@
second.style = "view-transition-name: target";
});

// First domUpdated resolves since the callback runs successfully.
let domUpdatedResolved = false;
transition.domUpdated.then(() => { domUpdatedResolved = true; }, reject);
// First updateCallbackDone resolves since the callback runs successfully.
let updateCallbackDoneResolved = false;
transition.updateCallbackDone.then(() => { updateCallbackDoneResolved = true; }, reject);

// Then finished resolves since domUpdated was already resolved.
// Then finished resolves since updateCallbackDone was already resolved.
let finishResolved = false;
transition.domUpdated.then(() => {
assert_true(domUpdatedResolved, "domUpdated not resolved before finish");
transition.updateCallbackDone.then(() => {
assert_true(updateCallbackDoneResolved, "updateCallbackDone not resolved before finish");
finishResolved = true;
}, reject);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
return new Promise(async (resolve, reject) => {
let transition = document.startViewTransition();
await transition.domUpdated;
await transition.updateCallbackDone;
await transition.ready;

transition.finished.then(resolve, reject);
Expand Down
6 changes: 3 additions & 3 deletions css/css-view-transitions/no-containment-on-new-element.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
let readyRejected = false;
transition.ready.then(reject, () => { readyRejected = true; });

let domUpdated = false;
transition.domUpdated.then(() => { domUpdated = true; }, reject);
let updateCallbackDone = false;
transition.updateCallbackDone.then(() => { updateCallbackDone = true; }, reject);
transition.finished.then(() => {
assert_true(readyRejected, "ready not rejected");
assert_true(domUpdated, "dom not updated");
assert_true(updateCallbackDone, "dom not updated");

if (window.getComputedStyle(first).contain == "none")
resolve();
Expand Down
6 changes: 3 additions & 3 deletions css/css-view-transitions/no-containment-on-old-element.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
let readyRejected = false;
transition.ready.then(reject, () => { readyRejected = true; });

let domUpdated = false;
transition.domUpdated.then(() => { domUpdated = true; }, reject);
let updateCallbackDone = false;
transition.updateCallbackDone.then(() => { updateCallbackDone = true; }, reject);
transition.finished.then(() => {
assert_true(readyRejected, "ready not rejected");
assert_true(domUpdated, "dom not updated");
assert_true(updateCallbackDone, "dom not updated");

if (window.getComputedStyle(first).contain == "paint")
resolve();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
return new Promise(async (resolve, reject) => {
let transition = document.startViewTransition();
await transition.domUpdated;
await transition.updateCallbackDone;
await transition.ready;

let viewbox = window.getComputedStyle(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
});

let dom_updated_resolved = false;
transition.domUpdated.then(() => {
transition.updateCallbackDone.then(() => {
if (!dom_change_ran)
reject();
// If there's a rAF before ready resolves, we fail.
Expand All @@ -47,5 +47,5 @@
resolve();
});
});
}, "domUpdated resolves, then ready resolves with no rAF in between");
}, "updateCallbackDone resolves, then ready resolves with no rAF in between");
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@
else
reject();
});
}, "finished promise should be resolved if skipTransition() is invoked before a synchronous domUpdated callback is dispatched");
}, "finished promise should be resolved if skipTransition() is invoked before a synchronous updateCallbackDone callback is dispatched");
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
transition.ready.then(reject, () => { readyRejected = true; });

let domUpdateRejected = false;
transition.domUpdated.then(reject, () => { domUpdateRejected = true; });
transition.updateCallbackDone.then(reject, () => { domUpdateRejected = true; });
transition.finished.then(reject, () => {
assert_true(readyRejected, "ready not rejected");
assert_true(domUpdateRejected, "dom update not rejected");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
return new Promise(async (resolve, reject) => {
let transition = document.startViewTransition();
await transition.domUpdated;
await transition.updateCallbackDone;

// Elements with view-transition-name: initial and unset don't have
// containment. Because they are ignored they don't cause the transition to
Expand Down

0 comments on commit ba9de5e

Please sign in to comment.