Skip to content

Commit

Permalink
Refactor nested-navigations resource-timing flow
Browse files Browse the repository at this point in the history
This changes how frames, iframes & objects decide how to report
their navigations as resource timing entries to their parent:

- Any frame-initiated navigation (e.g. iframe.src change) is
  reported as an entry. This complies with current spec.
- For nested navigations that fail Timing-Allow-Origin, we don't
  report the normal responseEnd - instead we report the load event
  time as the responseEnd, to prevent leakage of navigation-related
  cross-origin information
  (see w3c/resource-timing#340)

This incidentally fixes other existing issues with nested navigations
and resource timing, such as flaky tests and inconsistencies regarding
restored iframes.

Bug: 1404695
Bug: 1348080
Bug: 1290721
Bug: 1380078
Bug: 1378015
Bug: 957181

Spec changes: whatwg/html#8643
whatwg/fetch#1579

Change-Id: I010b026788193cc77a7de3f3d75304602f41fcd5
  • Loading branch information
noamr authored and chromium-wpt-export-bot committed Jan 9, 2023
1 parent 8c1683d commit bfe15f6
Show file tree
Hide file tree
Showing 6 changed files with 111 additions and 46 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@
document.body.appendChild(childFrame)

performance.mark("entry-name")
const loadPromise = new Promise(resolve => window.addEventListener("load", resolve))

childFrame.addEventListener('load', () => {
childFrame.addEventListener('load', async () => {
await loadPromise
const entries = performance.getEntries(true)
window.parent.postMessage(entries.length, "*")
})
</script>
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@
document.body.appendChild(childFrame)

performance.mark("entry-name")
const loadPromise = new Promise(resolve => window.addEventListener("load", resolve));

childFrame.addEventListener('load', () => {
childFrame.addEventListener('load', async () => {
await loadPromise;
const entries = performance.getEntries(true)
window.parent.postMessage(entries.length, "*")
})
</script>
</script>
15 changes: 14 additions & 1 deletion resource-timing/iframe-sequence-of-events.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,22 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/frame-timing.js"></script>
<script src="/common/utils.js"></script>
<script src="/common/get-host-info.sub.js"></script>
<body>
<script>
test_frame_timing_before_load_event('iframe');
test_frame_timing_change_src('iframe');

const host_info = get_host_info();
const types = ['ORIGIN', 'HTTP_REMOTE_ORIGIN', 'HTTP_NOTSAMESITE_ORIGIN'];
for (const a of types) {
for (const b of types) {
for (const tao of [true, false]) {
test_frame_timing_change_src('iframe', host_info[a], host_info[b], tao,
`Changing the src of an iframe (${a}->${b}) ${tao ? "with" : "without"} TAO should result in an RT entry`);
}
}
}
</script>
</body>
</body>
33 changes: 33 additions & 0 deletions resource-timing/nested-nav-fallback-timing.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Test ResourceTiming reporting for cross-origin iframe.</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/common/get-host-info.sub.js"></script>
<script src="resources/observe-entry.js"></script>
</head>
<body>
<body>
<script>
const {REMOTE_ORIGIN} = get_host_info();

promise_test(async t => {
const iframe = document.createElement('iframe');
t.add_cleanup(() => iframe.remove());
iframe.src = `${REMOTE_ORIGIN}/resource-timing/resources/delay-load.html`;
document.body.appendChild(iframe);
const entry = await observe_entry(iframe.src);
assert_greater_than(entry.duration, 1000);
}, "Cross-origin TAO-fail IFrame entries should report window load time");

promise_test(async t => {
const object = document.createElement('object');
object.type = "text/html";
t.add_cleanup(() => object.remove());
object.data = `${REMOTE_ORIGIN}/resource-timing/resources/delay-load.html`;
document.body.appendChild(object);
const entry = await observe_entry(object.data);
assert_greater_than(entry.duration, 1000);
}, "Cross-origin TAO-fail object entries should report window load time");

</script>
4 changes: 4 additions & 0 deletions resource-timing/resources/delay-load.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<!DOCTYPE html>
<body>
<img src="/images/blue.png?pipe=trickle(d1)">
</body>
93 changes: 52 additions & 41 deletions resource-timing/resources/frame-timing.js
Original file line number Diff line number Diff line change
@@ -1,48 +1,59 @@
function test_frame_timing_before_load_event(type) {
promise_test(async t => {
const {document, performance} = type === 'frame' ? window.parent : window;
const delay = 500;
const frame = document.createElement(type);
t.add_cleanup(() => frame.remove());
await new Promise(resolve => {
frame.addEventListener('load', resolve);
frame.src = `resources/iframe-with-delay.sub.html?delay=${delay}`;
(type === 'frame' ? document.querySelector('frameset') : document.body).appendChild(frame);
});
promise_test(async t => {
const {document, performance} = type === 'frame' ? window.parent : window;
const delay = 500;
const frame = document.createElement(type);
t.add_cleanup(() => frame.remove());
await new Promise(resolve => {
frame.addEventListener('load', resolve);
frame.src = `/resource-timing/resources/iframe-with-delay.sub.html?delay=${delay}`;
(type === 'frame' ? document.querySelector('frameset') : document.body).appendChild(frame);
});

const entries = performance.getEntriesByName(frame.src);
const navigationEntry = frame.contentWindow.performance.getEntriesByType('navigation')[0];
assert_equals(entries.length, 1);
assert_equals(entries[0].initiatorType, type);
assert_greater_than(performance.now(), entries[0].responseEnd + delay);
const domContentLoadedEventAbsoluteTime = navigationEntry.domContentLoadedEventStart + frame.contentWindow.performance.timeOrigin;
const frameResponseEndAbsoluteTime = entries[0].responseEnd + performance.timeOrigin;
assert_greater_than(domContentLoadedEventAbsoluteTime, frameResponseEndAbsoluteTime);
}, `A ${type} should report its RT entry when the response is done and before it is completely loaded`);
const entries = performance.getEntriesByName(frame.src);
const navigationEntry = frame.contentWindow.performance.getEntriesByType('navigation')[0];
assert_equals(entries.length, 1);
assert_equals(entries[0].initiatorType, type);
assert_greater_than(performance.now(), entries[0].responseEnd + delay);
const domContentLoadedEventAbsoluteTime = navigationEntry.domContentLoadedEventStart + frame.contentWindow.performance.timeOrigin;
const frameResponseEndAbsoluteTime = entries[0].responseEnd + performance.timeOrigin;
assert_greater_than(domContentLoadedEventAbsoluteTime, frameResponseEndAbsoluteTime);
}, `A ${type} should report its RT entry when the response is done and before it is completely loaded`);
}


function test_frame_timing_change_src(type) {
promise_test(async t => {
const {document, performance} = type === 'frame' ? window.parent : window;
const frame = document.createElement(type);
t.add_cleanup(() => frame.remove());
await new Promise(resolve => {
const done = () => {
resolve();
frame.removeEventListener('load', done);
}
frame.addEventListener('load', done);
frame.src = 'resources/green.html?1';
(type === 'frame' ? document.querySelector('frameset') : document.body).appendChild(frame);
});
function test_frame_timing_change_src(type, origin1 = document.origin, origin2 = document.origin, tao = false, label = '') {
const uid = token();
promise_test(async t => {
const {document, performance} = type === 'frame' ? window.parent : window;
const frame = document.createElement(type);
t.add_cleanup(() => frame.remove());
function createURL(origin, iteration) {
const url = new URL(`${origin}/resource-timing/resources/green.html`, location.href);
url.searchParams.set("uid", uid);
url.searchParams.set("iteration", iteration);
if (tao)
url.searchParams.set("pipe", "header(Timing-Allow-Origin, *)");
return url.toString();
}

await new Promise(resolve => {
frame.addEventListener('load', resolve);
frame.src = 'resources/green.html?2';
});
await new Promise(resolve => {
const done = () => {
resolve();
frame.removeEventListener('load', done);
}
frame.addEventListener('load', done);
frame.src = createURL(origin1, 1);
const root = type === 'frame' ? document.querySelector('frameset') : document.body;
root.appendChild(frame);
});

const entries = performance.getEntries().filter(e => e.name.includes('green.html'));
assert_equals(entries.length, 2);
}, `A ${type} should report separate RT entries if its src changed from the outside`);
}
await new Promise(resolve => {
frame.addEventListener('load', resolve);
frame.src = createURL(origin2, 1);
});

const entries = performance.getEntries().filter(e => e.name.includes(uid));
assert_equals(entries.length, 2);
}, label || `A ${type} should report separate RT entries if its src changed from the outside`);
}

0 comments on commit bfe15f6

Please sign in to comment.