Skip to content

Commit

Permalink
getCapabilities() should not have range properties without valid values
Browse files Browse the repository at this point in the history
This CL ensures that MediaStreamTrack.getCapabilities() does not have
range properties if they don't have a valid range.

Bug: 293292
Change-Id: I6f85086fb4af7e17faca069f76299a0256f1872d
Reviewed-on: https://chromium-review.googlesource.com/938983
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539778}
  • Loading branch information
chandanpadhi authored and chromium-wpt-export-bot committed Feb 28, 2018
1 parent 5107187 commit ca3bede
Showing 1 changed file with 6 additions and 17 deletions.
23 changes: 6 additions & 17 deletions mediacapture-streams/MediaStreamTrack-getCapabilities.https.html
Expand Up @@ -6,24 +6,13 @@
<script src=/resources/testharnessreport.js></script>
<script>
promise_test(() => {
return navigator.mediaDevices.getUserMedia({audio: true})
return navigator.mediaDevices.getUserMedia({audio: true, video: true})
.then(stream => {
var capabilities = stream.getAudioTracks()[0].getCapabilities();
assert_true(undefined !== capabilities.deviceId, "MediaTrackCapabilities's deviceId should exist.");
assert_true(undefined !== capabilities.echoCancellation, "MediaTrackCapabilities's echoCancellation should exist.");
});
});

promise_test(() => {
return navigator.mediaDevices.getUserMedia({video: true})
.then(stream => {
var capabilities = stream.getVideoTracks()[0].getCapabilities();
assert_true(undefined !== capabilities.deviceId, "MediaTrackCapabilities's deviceId should exist.");
assert_true(undefined !== capabilities.width, "MediaTrackCapabilities's width should exist.");
assert_true(undefined !== capabilities.height, "MediaTrackCapabilities's height should exist.");
assert_true(undefined !== capabilities.aspectRatio, "MediaTrackCapabilities's aspectRatio should exist.");
assert_true(undefined !== capabilities.frameRate, "MediaTrackCapabilities's frameRate should exist.");
assert_true(undefined !== capabilities.facingMode, "MediaTrackCapabilities's facingMode should exist.");
var audioCapabilities = stream.getAudioTracks()[0].getCapabilities();
var videoCapabilities = stream.getVideoTracks()[0].getCapabilities();
assert_true(undefined !== audioCapabilities.deviceId, "MediaTrackCapabilities's deviceId should exist for an audio track.");
assert_true(undefined !== audioCapabilities.echoCancellation, "MediaTrackCapabilities's echoCancellation should exist for an audio track.");
assert_true(undefined !== videoCapabilities.deviceId, "MediaTrackCapabilities's deviceId should exist for a video track.");
});
});
</script>

0 comments on commit ca3bede

Please sign in to comment.