Move dblclick disabled event test to separate file

In http://crrev.com/1225838 I added dblclick testing to an interop2023 tracked test, which affected our scores. I am temporarily moving the dblclick testing to a separate file while we wait for interop2023 to end. Change-Id: I838e8e3851261bf1fd627b2406492945f26f3640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5050435 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1228123}
web-platform-tests · Nov 22, 2023 · d3feabf · d3feabf
1 parent 0173c88
commit d3feabf
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 13 deletions.
diff --git a/html/semantics/disabled-elements/disabled-event-dispatch-additional.tentative.html b/html/semantics/disabled-elements/disabled-event-dispatch-additional.tentative.html
@@ -0,0 +1,74 @@
+<!DOCTYPE html>
+<meta name="timeout" content="long">
+<link rel=author href="mailto:jarhar@chromium.org">
+<link rel=help href="https://github.com/whatwg/html/issues/2368">
+<link rel=help href="https://github.com/whatwg/html/issues/5886">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
+<script src="/resources/testdriver-actions.js"></script>
+
+<!-- This test should be merged with disabled-event-dispatch.tentative.html after interop2023 is over. -->
+
+<div id=targetparent>
+  <button disabled>
+    hello world
+    <span style="border: 1px solid black">child</span>
+  </button>
+  <my-control disabled>
+    hello world
+    <span style="border: 1px solid black">child</span>
+  </my-control>
+</div>
+
+<script>
+customElements.define('my-control', class extends HTMLElement {
+  static get formAssociated() { return true; }
+});
+
+['dblclick', 'auxclick'].forEach(eventName => {
+  [true, false].forEach(clickChildElement => {
+    for (const target of targetparent.children) {
+      promise_test(async () => {
+        let parentReceivedEvent = false;
+        targetparent.addEventListener(eventName, () => parentReceivedEvent = true);
+
+        let targetReceivedEvent = false;
+        target.addEventListener(eventName, () => targetReceivedEvent = true);
+
+        let childReceivedEvent = false;
+        let targetchild = target.firstElementChild;
+        targetchild.addEventListener(eventName, () => childReceivedEvent = true);
+
+        const elementToClick = clickChildElement ? targetchild : target;
+        if (eventName === 'dblclick') {
+          await (new test_driver.Actions()
+            .pointerMove(1, 1, {origin: elementToClick})
+            .pointerDown()
+            .pointerUp()
+            .pointerDown()
+            .pointerUp())
+            .send();
+        } else if (eventName === 'auxclick') {
+          const actions = new test_driver.Actions();
+          await actions
+            .pointerMove(1, 1, {origin: elementToClick})
+            .pointerDown({button: actions.ButtonType.MIDDLE})
+            .pointerUp({button: actions.ButtonType.MIDDLE})
+            .send();
+        }
+
+
+        const shouldReceiveEvents = eventName.startsWith('pointer') || eventName === 'auxclick';
+        assert_equals(parentReceivedEvent, shouldReceiveEvents,
+                      `parent element received ${eventName} events`);
+        assert_equals(targetReceivedEvent, shouldReceiveEvents,
+                      `target element received ${eventName} events`);
+        assert_equals(childReceivedEvent, clickChildElement,
+                      `child element received ${eventName} events`);
+      }, `Testing ${eventName} events when clicking ${clickChildElement ? 'child of ' : ''}disabled ${target.localName}.`);
+    }
+  });
+});
+</script>
diff --git a/html/semantics/disabled-elements/disabled-event-dispatch.tentative.html b/html/semantics/disabled-elements/disabled-event-dispatch.tentative.html
@@ -25,7 +25,7 @@
   static get formAssociated() { return true; }
 });
 
-['mousedown', 'mouseup', 'pointerdown', 'pointerup', 'click', 'dblclick'].forEach(eventName => {
+['mousedown', 'mouseup', 'pointerdown', 'pointerup', 'click'].forEach(eventName => {
   [true, false].forEach(clickChildElement => {
     for (const target of targetparent.children) {
       promise_test(async () => {
@@ -39,18 +39,7 @@
         let targetchild = target.firstElementChild;
         targetchild.addEventListener(eventName, () => childReceivedEvent = true);
 
-        const elementToClick = clickChildElement ? targetchild : target;
-        if (eventName === 'dblclick') {
-          await (new test_driver.Actions()
-            .pointerMove(1, 1, {origin: elementToClick})
-            .pointerDown()
-            .pointerUp()
-            .pointerDown()
-            .pointerUp())
-            .send();
-        } else {
-          await test_driver.click(elementToClick);
-        }
+        await test_driver.click(clickChildElement ? targetchild : target);
 
         const parentShouldReceiveEvents = eventName.startsWith('pointer');
         assert_equals(parentReceivedEvent, parentShouldReceiveEvents,