Skip to content

Commit

Permalink
Change "mute" invoke action to toggleMuted
Browse files Browse the repository at this point in the history
See openui/open-ui#933 for details

Bug: 1497172, 1497173
Change-Id: I193b9948bd6b296d9a3e85e0dac3de780ae1865f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5073272
Commit-Queue: Luke <lukewarlow156@gmail.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1230938}
  • Loading branch information
lukewarlow authored and chromium-wpt-export-bot committed Nov 29, 2023
1 parent 2eaa093 commit ded643e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,13 @@
invokee.muted = false;
});
assert_false(invokee.muted);
invokerbutton.setAttribute("invokeaction", "mute");
invokerbutton.setAttribute("invokeaction", "toggleMuted");
await clickOn(invokerbutton);
await new Promise(resolve => {
requestAnimationFrame(resolve);
});
assert_true(invokee.muted);
}, "invoking audio with mute action mutes it");
}, "invoking audio with toggleMuted action mutes it");

promise_test(async function (t) {
t.add_cleanup(async () => {
Expand All @@ -257,13 +257,13 @@
once: true,
});
assert_false(invokee.muted);
invokerbutton.setAttribute("invokeaction", "mute");
invokerbutton.setAttribute("invokeaction", "toggleMuted");
await clickOn(invokerbutton);
await new Promise(resolve => {
requestAnimationFrame(resolve);
});
assert_false(invokee.muted);
}, "invoking audio with mute action and preventDefault is a no-op");
}, "invoking audio with toggleMuted action and preventDefault is a no-op");

promise_test(async function (t) {
t.add_cleanup(async () => {
Expand All @@ -274,12 +274,12 @@
});
invokee.muted = true;
assert_true(invokee.muted);
invokerbutton.setAttribute("invokeaction", "mute");
invokerbutton.setAttribute("invokeaction", "toggleMuted");
await clickOn(invokerbutton);
await new Promise(resolve => {
requestAnimationFrame(resolve);
});
assert_false(invokee.muted);
}, "invoking muted audio with mute action unmutes it");
}, "invoking muted audio with toggleMuted action unmutes it");

</script>
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,13 @@
invokee.muted = false;
});
assert_false(invokee.muted);
invokerbutton.setAttribute("invokeaction", "mute");
invokerbutton.setAttribute("invokeaction", "toggleMuted");
await clickOn(invokerbutton);
await new Promise(resolve => {
requestAnimationFrame(resolve);
});
assert_true(invokee.muted);
}, "invoking video with mute action mutes it");
}, "invoking video with toggleMuted action mutes it");

promise_test(async function (t) {
t.add_cleanup(async () => {
Expand All @@ -225,13 +225,13 @@
once: true,
});
assert_false(invokee.muted);
invokerbutton.setAttribute("invokeaction", "mute");
invokerbutton.setAttribute("invokeaction", "toggleMuted");
await clickOn(invokerbutton);
await new Promise(resolve => {
requestAnimationFrame(resolve);
});
assert_false(invokee.muted);
}, "invoking video with mute action and preventDefault is a no-op");
}, "invoking video with toggleMuted action and preventDefault is a no-op");

promise_test(async function (t) {
t.add_cleanup(async () => {
Expand All @@ -242,12 +242,12 @@
});
invokee.muted = true;
assert_true(invokee.muted);
invokerbutton.setAttribute("invokeaction", "mute");
invokerbutton.setAttribute("invokeaction", "toggleMuted");
await clickOn(invokerbutton);
await new Promise(resolve => {
requestAnimationFrame(resolve);
});
assert_false(invokee.muted);
}, "invoking muted video with mute action unmutes it");
}, "invoking muted video with toggleMuted action unmutes it");

</script>

0 comments on commit ded643e

Please sign in to comment.