Skip to content

Commit

Permalink
<input type=time> with datalist triggers !IsValid() DCHECK
Browse files Browse the repository at this point in the history
1) Only perform validity checks on truly plain text fields.
   We considered removing the check, but it still has value in terms
   of catching situations where the text field structure changes,
   which have occurred in the past and caused regressions.
2) Remove BrowserAccessibility::IsValid() from non-DCHECK builds.

Bug: 1221781
NOTRY: true
Change-Id: I5719fa84950f038f19ebe9c616db5946c52e0242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983437
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#897069}
  • Loading branch information
aleventhal authored and chromium-wpt-export-bot committed Jun 29, 2021
1 parent 950275f commit e8652a6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions accessibility/crashtests/input-time-datalist.html
@@ -0,0 +1,2 @@
<input type=time list="suggestions">
<datalist id=suggestions>

0 comments on commit e8652a6

Please sign in to comment.