Skip to content

Commit

Permalink
Merge pull request #10180 from rsolomakhin/method
Browse files Browse the repository at this point in the history
Replace 'enabledMethods' array with 'method' string.
  • Loading branch information
rsolomakhin committed Mar 27, 2018
2 parents 6135f17 + c5e2e61 commit e96e038
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion interfaces/payment-handler.idl
Expand Up @@ -19,7 +19,7 @@ interface PaymentInstruments {
dictionary PaymentInstrument {
required DOMString name;
sequence<ImageObject> icons;
sequence<DOMString> enabledMethods;
DOMString method;
object capabilities;
};
dictionary ImageObject {
Expand Down
6 changes: 3 additions & 3 deletions payment-handler/can-make-payment-event.https.html
Expand Up @@ -24,7 +24,7 @@
}
await registration.paymentManager.instruments.set(instrumentKey, {
name: 'Test Payment Method',
enabledMethods: [methodName],
method: methodName,
});
return registration;
}
Expand Down Expand Up @@ -310,7 +310,7 @@
const registration = await registerApp(methodName);
await registration.paymentManager.instruments.set(instrumentKey, {
name: 'Test Payment Method',
enabledMethods: [methodName],
method: methodName,
capabilities: {
supportedTypes: [cardType],
supportedNetworks: [cardNetwork],
Expand Down Expand Up @@ -360,7 +360,7 @@
const registration = await registerApp(methodName);
await registration.paymentManager.instruments.set(instrumentKey, {
name: 'Test Payment Method',
enabledMethods: [methodName],
method: methodName,
capabilities: {
supportedTypes: [cardType],
supportedNetworks: [cardNetwork],
Expand Down
28 changes: 14 additions & 14 deletions payment-handler/payment-instruments.https.html
Expand Up @@ -76,7 +76,7 @@
type: 'image/png',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
capabilities: {supportedNetworks: ['mir'], supportedTypes: ['prepaid']},
},
);
Expand All @@ -103,7 +103,7 @@
icons: [
{src: '/images/green-16x16.png', sizes: '16x16', type: 'image/png'},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
capabilities: {supportedNetworks: ['mir'], supportedTypes: ['prepaid']},
},
);
Expand All @@ -118,7 +118,7 @@
);
assert_equals(result.icons[0].sizes, '16x16');
assert_equals(result.icons[0].type, 'image/png');
assert_array_equals(result.enabledMethods, ['basic-card']);
assert_equals(result.method, 'basic-card');
assert_array_equals(result.capabilities.supportedNetworks, ['mir']);
assert_array_equals(result.capabilities.supportedTypes, ['prepaid']);
await registration.paymentManager.instruments.set(
Expand All @@ -132,7 +132,7 @@
type: 'image/png',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
capabilities: {supportedNetworks: ['visa'], supportedTypes: ['credit']},
},
);
Expand All @@ -147,7 +147,7 @@
);
assert_equals(result.icons[0].sizes, '256x256');
assert_equals(result.icons[0].type, 'image/png');
assert_array_equals(result.enabledMethods, ['basic-card']);
assert_equals(result.method, 'basic-card');
assert_array_equals(result.capabilities.supportedNetworks, ['visa']);
assert_array_equals(result.capabilities.supportedTypes, ['credit']);
}, 'Resetting an existing instrument updates the instrument');
Expand All @@ -165,7 +165,7 @@
type: 'image/png',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
capabilities: {supportedNetworks: ['mir'], supportedTypes: ['prepaid']},
},
);
Expand All @@ -189,7 +189,7 @@
type: 'image/jif',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
},
);
return promise_rejects(t, new TypeError(), setPromise);
Expand All @@ -208,7 +208,7 @@
type: 'image/pn' + 'g'.repeat(1000),
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
},
);
return promise_rejects(t, new TypeError(), setPromise);
Expand All @@ -225,7 +225,7 @@
type: 'image/png',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
});
}, "Don't crash when registering an instrument with a very long icon size 888...x888...");

Expand All @@ -242,7 +242,7 @@
type: 'image/png',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
},
);
return promise_rejects(t, new TypeError(), setPromise);
Expand All @@ -261,7 +261,7 @@
type: 'image/png',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
},
);
return promise_rejects(t, new TypeError(), setPromise);
Expand All @@ -280,7 +280,7 @@
type: 'image/png',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
},
);
return promise_rejects(t, new TypeError(), setPromise);
Expand All @@ -300,7 +300,7 @@
type: 'image/gif',
},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
},
);
return promise_rejects(t, new TypeError(), setPromise);
Expand All @@ -313,7 +313,7 @@
icons: [
{src: '/images/rgrg-256x256.png', sizes: '256x256', type: 'image/png'},
],
enabledMethods: [existingKey],
method: existingKey,
capabilities: {aCapabilityName: existingKey},
});
const hasExistingInstrument = await registration.paymentManager.instruments.has(
Expand Down
2 changes: 1 addition & 1 deletion payment-handler/payment-request-event.https.html
Expand Up @@ -15,7 +15,7 @@
icons: [
{src: '/images/rgrg-256x256.png', sizes: '256x256', type: 'image/png'},
],
enabledMethods: ['basic-card'],
method: 'basic-card',
capabilities: {supportedNetworks: ['mir'], supportedTypes: ['prepaid']},
});
runTests();
Expand Down

0 comments on commit e96e038

Please sign in to comment.