Skip to content

Commit

Permalink
Ignore order when parsing inset and color for box-shadow
Browse files Browse the repository at this point in the history
According to the spec [1], box-shadow should allow the inset keyword and
a color in any order. Our implementation allowed only 2 out of the 4
possible orders; fix our parsing to match the spec.

[1]: https://drafts.csswg.org/css-backgrounds/#typedef-shadow

Bug: 811083
Change-Id: I54c3d15c177702624994c45044b446fd82fc9d98
Reviewed-on: https://chromium-review.googlesource.com/911994
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536270}
  • Loading branch information
csnardi authored and chromium-wpt-export-bot committed Feb 13, 2018
1 parent 826c76d commit f27d188
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion css/css-backgrounds/box-shadow-syntax-001.xht
Expand Up @@ -21,7 +21,7 @@
}
.inset {
color: green;
height: 13px;
height: 12px;
margin: -1px 0 -4px -4px;
}

Expand Down
1 change: 1 addition & 0 deletions css/css-backgrounds/reference/box-shadow-syntax-001.xht
Expand Up @@ -10,6 +10,7 @@
border: solid green 4px;
padding-top: 1px;
border-style: none none solid solid;
height: 7px;
}
</style>
</head>
Expand Down

0 comments on commit f27d188

Please sign in to comment.