Skip to content

Commit

Permalink
Lab with 100 lightness is always white, tests must reflect that
Browse files Browse the repository at this point in the history
We were marked as failing these for interop 2023 once
https://chromium-review.googlesource.com/c/chromium/src/+/4928209
was merged.

Tests automatically being suppressed by TestExpectations isn't great!

Bug: 1502301
Change-Id: I452c101d9db3e0204f24fc554362ff1999534f6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5029018
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1225681}
  • Loading branch information
mysteryDate authored and chromium-wpt-export-bot committed Nov 16, 2023
1 parent fbf6058 commit f464e65
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion css/css-color/xyz-003-ref.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<title>CSS Color 4: CSS Color 4: xyz</title>
<style>
body { background-color: grey; }
.test { background-color: lab(100.115% 9.06448 5.80177); width: 12em; height: 12em; } /* color(xyz 1 1 1) converted to Lab */
.test { background-color: color(srgb 1.08516 0.97699 0.958832); width: 12em; height: 12em; } /* color(xyz 1 1 1) converted to sRGB */
</style>
<body>
<p>Test passes if you see a single square, and not two rectangles of different colors.</p>
Expand Down
2 changes: 1 addition & 1 deletion css/css-color/xyz-003.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<style>
body { background-color: grey; }
.test { background-color: red; width: 12em; height: 6em; margin-top: 0; }
.ref { background-color: lab(100.115% 9.06448 5.80177); width: 12em; height: 6em; margin-bottom: 0; } /* color(xyz 1 1 1) converted to Lab */
.ref { background-color: color(srgb 1.08516 0.97699 0.958832); width: 12em; height: 6em; margin-bottom: 0; } /* color(xyz 1 1 1) converted to sRGB */
.test { background-color: color(xyz 1 1 1); }
</style>
<body>
Expand Down
2 changes: 1 addition & 1 deletion css/css-color/xyz-d65-003-ref.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<title>CSS Color 4: CSS Color 4: xyz-d65</title>
<style>
body { background-color: grey; }
.test { background-color: lab(100.115% 9.06448 5.80177); width: 12em; height: 12em; } /* color(xyz-d65 1 1 1) converted to Lab */
.test { background-color: color(srgb 1.08516 0.97699 0.958832); width: 12em; height: 12em; } /* color(xyz-d65 1 1 1) converted to sRGB */
</style>
<body>
<p>Test passes if you see a single square, and not two rectangles of different colors.</p>
Expand Down
2 changes: 1 addition & 1 deletion css/css-color/xyz-d65-003.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<style>
body { background-color: grey; }
.test { background-color: red; width: 12em; height: 6em; margin-top: 0; }
.ref { background-color: lab(100.115% 9.06448 5.80177); width: 12em; height: 6em; margin-bottom: 0; } /* color(xyz-d65 1 1 1) converted to Lab */
.ref { background-color: color(srgb 1.08516 0.97699 0.958832); width: 12em; height: 6em; margin-bottom: 0; } /* color(xyz-d65 1 1 1) converted to sRGB */
.test { background-color: color(xyz-d65 1 1 1); }
</style>
<body>
Expand Down

0 comments on commit f464e65

Please sign in to comment.