Skip to content

Commit

Permalink
[FedCM] Rename given_name to givenName in IdentityUserInfo
Browse files Browse the repository at this point in the history
Fixed: 1445775
Change-Id: I038ac72f3df8e20961cc78a5fcbe95b828a3f028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566448
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149284}
  • Loading branch information
npm1 authored and pull[bot] committed Jan 4, 2024
1 parent c32ed85 commit fd038d2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions credential-management/fedcm-network-requests.https.html
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,9 @@
assert_equals(message.result, "Pass");
assert_equals(message.numAccounts, 1);
assert_equals(message.firstAccountEmail, "john_doe@idp.example");
assert_equals(message.firstAccountName, "John Doe");
assert_equals(message.firstAccountGivenName, "John");
assert_equals(message.firstAccountPicture, "https://idp.example/profile/123");
}, 'Test basic User InFo API flow');

fedcm_test(async t => {
Expand Down
5 changes: 4 additions & 1 deletion credential-management/support/fedcm/userinfo-iframe.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
let results = {
result: "Pass",
numAccounts: user_info.length,
firstAccountEmail: user_info[0].email
firstAccountEmail: user_info[0].email,
firstAccountName: user_info[0].name,
firstAccountGivenName: user_info[0].givenName,
firstAccountPicture: user_info[0].picture
};
window.top.postMessage(results, '*');
} catch (error) {
Expand Down

0 comments on commit fd038d2

Please sign in to comment.