Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/IndexedDB/idbdatabase-createObjectStore-exception-order.htm is disabled in Mozilla and flaky in WebKit #10792

Closed
zcorpan opened this issue May 2, 2018 · 5 comments
Assignees
Labels

Comments

@zcorpan
Copy link
Member

zcorpan commented May 2, 2018

http://bocoup.github.io/wpt-disabled-tests-report/

Investigate what's up with this test:

Path Products Results Bugs
/IndexedDB/idbdatabase-createObjectStore-exception-order.htm mozilla webkit disabled [ Pass Failure ] https://bugzilla.mozilla.org/show_bug.cgi?id=1336639 https://webkit.org/b/172243
@zcorpan
Copy link
Member Author

zcorpan commented May 9, 2018

@jeffcarp @bevis-tseng any idea how to fix this test?

@zcorpan
Copy link
Member Author

zcorpan commented May 15, 2018

cc @inexorabletash and @pwnall

@zcorpan zcorpan assigned inexorabletash and unassigned zcorpan Jun 21, 2018
@inexorabletash
Copy link
Contributor

I'll try and take a look.

(Best guess from code inspection is that the browsers are not following the spec to the letter and so the work done in the setTimeout() races with the abort() call actually aborting the transaction, rather than the abort being processed immediately.)

@inexorabletash
Copy link
Contributor

Hrm, in FF52 at least the failure is due to the error bubbling up to window.onerror. Fixed by either

setup({allow_uncaught_exception:true});

or:

@@ -8,9 +8,11 @@
 <script>
 
 indexeddb_test(
-  (t, db, txn) => {
+  (t, db, txn, rq) => {
     db.createObjectStore('s');
 
+    rq.onerror = e => { e.preventDefault(); };
+
     txn.onabort = () => {

@inexorabletash
Copy link
Contributor

I had thought that FF was removing the event bubbling for IDB since the other browsers hadn't implemented it yet (although we plan to in Chrome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants