Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/workers/opaque-origin.html is disabled/flaky in chromium webkit #11188

Closed
zcorpan opened this issue May 28, 2018 · 4 comments
Closed

/workers/opaque-origin.html is disabled/flaky in chromium webkit #11188

zcorpan opened this issue May 28, 2018 · 4 comments
Assignees
Labels

Comments

@zcorpan
Copy link
Member

zcorpan commented May 28, 2018

http://bocoup.github.io/wpt-disabled-tests-report/

Investigate what's up with this test:

Path Products Results Bugs
/workers/opaque-origin.html chromium webkit [ Failure Crash Timeout ] [ Skip ] https://crbug.com/626703 None

cc @mkruisselbrink

I think the issue is that the test isn't enabling the port message queue, it needs channel.port1.start();

@mkruisselbrink
Copy link
Contributor

As mentioned on the pull request it seems the issue is that fetch_tests_from_worker used to auto-start the port (because it assigned to onmessage), and that later was changed to addEventListener('message', ...) instead. So presumably that could effect more than just this test (unless there is special code already to make sure a shared worker's port is started for example)?

@zcorpan
Copy link
Member Author

zcorpan commented Jun 21, 2018

@foolip can you update TestExpectations for chromium?

@cdumez can you update TestExpectations for webkit?

@zcorpan zcorpan reopened this Jun 21, 2018
@foolip
Copy link
Member

foolip commented Jul 17, 2018

Test enabled in https://chromium-review.googlesource.com/1140053.

aarongable pushed a commit to chromium/chromium that referenced this issue Jul 17, 2018
There haven't been any crashes or timeouts in a long time, only normal failures:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=%2Fworkers%2Fopaque-origin.html

See web-platform-tests/wpt#11188.

Change-Id: I933124b8c406fd202a7d382350cfe259d6607d79
Reviewed-on: https://chromium-review.googlesource.com/1140053
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575647}
@zcorpan
Copy link
Member Author

zcorpan commented May 8, 2019

Filed https://bugs.webkit.org/show_bug.cgi?id=197705 to get the test enabled in WebKit.

@zcorpan zcorpan closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants