Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize blocked port list #11346

Open
annevk opened this issue Jun 5, 2018 · 1 comment
Open

Centralize blocked port list #11346

annevk opened this issue Jun 5, 2018 · 1 comment

Comments

@annevk
Copy link
Member

annevk commented Jun 5, 2018

fetch/api/request/request-bad-port.html and websockets/Create-blocked-port.any.js both include the list of ports at https://fetch.spec.whatwg.org/#port-blocking. Perhaps we should store this list separately so it can be shared. (The one problem here is that if we store it as JSON and later the blocking logic becomes more complex (e.g., either in a range or in the list), we'll have to revamp the setup again.

Also sharing it with tools/wptserve/wptserve/utils.py is probably not a good idea, but I'm willing to be convinced otherwise.

@annevk
Copy link
Member Author

annevk commented Jun 5, 2018

(Suggested in #11249 by @Ms2ger.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants