Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin off testharness? #13072

Closed
tripu opened this issue Sep 19, 2018 · 5 comments
Closed

Spin off testharness? #13072

tripu opened this issue Sep 19, 2018 · 5 comments

Comments

@tripu
Copy link
Member

tripu commented Sep 19, 2018

ie, maintain testharness.js as a separate project and publish releases on npm.

(I think that's a minimum requirement if the authors want it to be adopted by others.)

cf w3c/nodejs#4

@jgraham
Copy link
Contributor

jgraham commented Sep 19, 2018

I'm not sure I understand the provenance of this issue. But I think that testharness.js should focus on being the best tool for writing web-platform-tests and not try to be a generic test harness for all scenarios; my experience is that the engineering tradeoffs are very different between a test runner designed for generic libraries and one that's designed specifically for testing the browser.

In terms of the repository, it used to be in a separate repo, but that turned out to have substantial overhead when making changes, so I'd be extremely reluctant to split it out again (this is linked to the goal of being the best thing for wpt tests specifically).

@tripu
Copy link
Member Author

tripu commented Sep 19, 2018

@jgraham: I actually agree with you. I was filing this issue “on behalf” of others who had expressed interest in bringing testharness.js to a wider audience, and who were defending its virtues as a generic JS testing tool (as opposed to just for WPT and the browser).

I'm waiting to see if somebody steps forward to defend the merits of this idea — otherwise, I'm happy to close this issue.

@plehegar
Copy link
Member

I don't think we need a separate repo for testharness.js in order to create an npm package....

@tripu
Copy link
Member Author

tripu commented Sep 26, 2018

“I don't think we need a separate repo for testharness.js in order to create an npm package....”

Okay by me; whatever the maintainer(s) find most appropriate :)

@tripu
Copy link
Member Author

tripu commented Oct 11, 2018

Closing this, since there seems to be consensus about testharness not needing to live in a separate GH repository (but I still think it'll have to be published independently via npm if you guys want any other project to adopt it in the future).

@tripu tripu closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants