Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to use ./wpt run --verify locally #15013

Open
foolip opened this issue Jan 23, 2019 · 1 comment · May be fixed by #15755
Open

Document how to use ./wpt run --verify locally #15013

foolip opened this issue Jan 23, 2019 · 1 comment · May be fixed by #15755
Labels
docs

Comments

@foolip
Copy link
Member

foolip commented Jan 23, 2019

I'm finding that when running ./wpt run --verify --channel dev --binary which google-chrome-unstable chrome /web-locks/signal.tentative.https.any.serviceworker.html locally (for #15012) all I get is "::: Test verification FAIL".

I couldn't guess if this meant the test is flaky or that something went wrong internally.

Looking at taskcluster-run.py I found that passing --log-mach - might fix the problem, and it does cause the extra stuff you see in Taskcluster to be printed.

Without that extra output ./wpt run --verify is not very useful. Might also consider changing the defaults.
@foolip foolip added the docs label Jan 23, 2019
@qiuzhong
Copy link
Contributor

I can reproduce this issue.
The wpt is based on mozlog utility. If the log formatter is not indicated in the command line explicitly, it's None. Maybe that's why all debug output was not printed. When --log-mach - is passed, the logger is set mach(Means human-readable output) and its value is sys.stdout.

Without that extra output ./wpt run --verify is not very useful. Might also consider changing the defaults.

Agreed. However, mozlog utility supports several log formatters (raw, unittest, xunit, html, mach tbpl, ). Should we change the default logger to mach when --verify option is set in the command line?

qiuzhong added a commit to qiuzhong/wpt that referenced this issue Mar 11, 2019
@qiuzhong
Set default log formatter when --verify is set
bf39363 
When no log formatter is set, `./wpt run --verify` is not useful as
no output is printed. This patch tries to set the default log formatter
to `log_mach` with the value of sys.stdout.
Fixed: web-platform-tests#15013
This was referenced Mar 11, 2019
Open
Open
qiuzhong added a commit to qiuzhong/wpt that referenced this issue Apr 11, 2019
@qiuzhong
Set default log formatter when --verify is set
a6a0b55 
When no log formatter is set, `./wpt run --verify` is not useful as
no output is printed. This patch tries to set the default log formatter
to `log_mach` with the value of sys.stdout.
Fixed: web-platform-tests#15013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set default log formatter when --verify is set qiuzhong/wpt
2 participants
@foolip @qiuzhong