-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebRTC callback methods need WPT tests #18236
Labels
Comments
chromium-wpt-export-bot
pushed a commit
that referenced
this issue
Jan 20, 2024
copied from webrtc/simplecall.https.html without cleaning up the style. See #18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Jan 21, 2024
copied from webrtc/simplecall.https.html without cleaning up the style. See web-platform-tests/wpt#18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249892}
chromium-wpt-export-bot
pushed a commit
that referenced
this issue
Jan 21, 2024
copied from webrtc/simplecall.https.html without cleaning up the style. See #18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249892}
chromium-wpt-export-bot
pushed a commit
that referenced
this issue
Jan 21, 2024
copied from webrtc/simplecall.https.html without cleaning up the style. See #18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249892}
https://wpt.fyi/results/webrtc/legacy/simplecall_callbacks.https.html?label=experimental&label=master&aligned |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Jan 24, 2024
…riant of simplecall, a=testonly Automatic update from web-platform-tests webrtc wpt: add legacy callback based variant of simplecall copied from webrtc/simplecall.https.html without cleaning up the style. See web-platform-tests/wpt#18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249892} -- wpt-commits: 5d54018efbafa6baa9e4da5cc7033ddf69476cf2 wpt-pr: 44110
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Jan 25, 2024
…riant of simplecall, a=testonly Automatic update from web-platform-tests webrtc wpt: add legacy callback based variant of simplecall copied from webrtc/simplecall.https.html without cleaning up the style. See web-platform-tests/wpt#18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <htachromium.org> Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Cr-Commit-Position: refs/heads/main{#1249892} -- wpt-commits: 5d54018efbafa6baa9e4da5cc7033ddf69476cf2 wpt-pr: 44110 UltraBlame original commit: 073cedf5049a831d7ef58d0b2ee268303264b7a8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Jan 25, 2024
…riant of simplecall, a=testonly Automatic update from web-platform-tests webrtc wpt: add legacy callback based variant of simplecall copied from webrtc/simplecall.https.html without cleaning up the style. See web-platform-tests/wpt#18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <htachromium.org> Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Cr-Commit-Position: refs/heads/main{#1249892} -- wpt-commits: 5d54018efbafa6baa9e4da5cc7033ddf69476cf2 wpt-pr: 44110 UltraBlame original commit: 073cedf5049a831d7ef58d0b2ee268303264b7a8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Jan 25, 2024
…riant of simplecall, a=testonly Automatic update from web-platform-tests webrtc wpt: add legacy callback based variant of simplecall copied from webrtc/simplecall.https.html without cleaning up the style. See web-platform-tests/wpt#18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <htachromium.org> Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Cr-Commit-Position: refs/heads/main{#1249892} -- wpt-commits: 5d54018efbafa6baa9e4da5cc7033ddf69476cf2 wpt-pr: 44110 UltraBlame original commit: 073cedf5049a831d7ef58d0b2ee268303264b7a8
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this issue
Jan 26, 2024
…riant of simplecall, a=testonly Automatic update from web-platform-tests webrtc wpt: add legacy callback based variant of simplecall copied from webrtc/simplecall.https.html without cleaning up the style. See web-platform-tests/wpt#18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249892} -- wpt-commits: 5d54018efbafa6baa9e4da5cc7033ddf69476cf2 wpt-pr: 44110
marcoscaceres
pushed a commit
that referenced
this issue
Feb 23, 2024
copied from webrtc/simplecall.https.html without cleaning up the style. See #18236 BUG=None Change-Id: Icbfb02768f455203f22b6bb357f448d31e323037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217871 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249892}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While the callback methods have been deprecated in favor of their promise-based brethren, it is still part of the WebRTC API; thus, they should have WPT tests.
More details in w3c/webrtc-pc#2022 (closed)
The text was updated successfully, but these errors were encountered: