Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypothesis health checks frequently fail #22758

Open
Hexcles opened this issue Apr 7, 2020 · 5 comments
Open

Hypothesis health checks frequently fail #22758

Hexcles opened this issue Apr 7, 2020 · 5 comments

Comments

@Hexcles
Copy link
Member

Hexcles commented Apr 7, 2020

Example: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=45217&view=logs&j=47b03e2b-d31e-537f-c8cf-66c80d147ca1&t=67b19343-5bc4-57b8-71e9-6c31e5bc256c&l=64

E hypothesis.errors.FailedHealthCheck: Data generation is extremely slow: Only produced 8 valid examples in 1.02 seconds (5 invalid ones and 4 exceeded maximum size). Try decreasing size of the data you're generating (with e.g.max_size or max_leaves parameters).
See https://hypothesis.readthedocs.io/en/latest/healthchecks.html for more information about this. If you want to disable just this health check, add HealthCheck.too_slow to the suppress_health_check settings for this test.

According to Azure: "This task has failed 12 times across 1042 pipeline runs in the last 14 days."

@Hexcles
Copy link
Member Author

Hexcles commented Apr 7, 2020

I'm going to temporarily disable this health check on Windows.

Hexcles added a commit that referenced this issue Apr 7, 2020
Hexcles added a commit that referenced this issue Apr 7, 2020
Hexcles added a commit that referenced this issue Apr 7, 2020
@Hexcles Hexcles changed the title Hypothesis health checks frequently fail on Windows Python 3.8 Hypothesis health checks frequently fail on Azure Apr 7, 2020
@Hexcles
Copy link
Member Author

Hexcles commented Apr 7, 2020

This fails on Mac, as well. In fact, it fails frequently only on Azure. Perhaps a performance issue?

Hexcles added a commit that referenced this issue Apr 8, 2020
@Hexcles Hexcles changed the title Hypothesis health checks frequently fail on Azure Hypothesis health checks frequently fail in Python 3 Apr 8, 2020
@Hexcles
Copy link
Member Author

Hexcles commented Apr 8, 2020

Actually, it also failed on Taskcluster (Linux)...

I've merged the workaround to disable the health check in Python 3, so I'm downgrading this to roadmap. @svillar could you investigate why Python 3 is slower when running these hypothesis tests?

@Hexcles
Copy link
Member Author

Hexcles commented Apr 8, 2020

It might be possible that the data generation has always been slow, and Python 3 implementation only pushed us a tad over the threshold. It'd be good if we can get the generation rates and compare them.

@svillar
Copy link
Contributor

svillar commented Apr 13, 2020

It might be possible that the data generation has always been slow, and Python 3 implementation only pushed us a tad over the threshold. It'd be good if we can get the generation rates and compare them.

I've run the test_manifest_to_json* tests with health checks on (--hypothesis-show-statistics) measuring the time required to complete the execution and it turns out that I'm consistently getting lower figures for python3 executions (7.2s vs 4.6s) so not sure what's going on.

Truth is, that for those tests data generation implies >98% of the time.

@Hexcles Hexcles changed the title Hypothesis health checks frequently fail in Python 3 Hypothesis health checks frequently fail Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants