Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadow-dom/resources/shadow-dom.js fails lintcheck #3193

Closed
zcorpan opened this issue Jun 20, 2016 · 2 comments
Closed

shadow-dom/resources/shadow-dom.js fails lintcheck #3193

zcorpan opened this issue Jun 20, 2016 · 2 comments
Assignees
@hayatoito

Comments

@zcorpan
Copy link
Member

zcorpan commented Jun 20, 2016

This change
4bcdc1e

causes new PRs to fail lintcheck because shadow-dom/resources/shadow-dom.js uses console.log (twice).

https://travis-ci.org/w3c/web-platform-tests/builds/138874205
@hayatoito
Copy link
Member

hayatoito commented Jun 20, 2016 •
edited
Loading

Ops. My bad. I did not realize that we have travis-ci and linkcheck for this repository. I'll fix it tomorrow. Please feel free to revert the change if we can not wait.

I guess commiting directory is no longer encouraged. Let me use PR from the next time.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 20, 2016

Thanks. I think it's OK to wait.

(If you want to keep the console.log you can add an exception in some whitelist file I believe.)

hayatoito added a commit to hayatoito/wpt that referenced this issue Jun 21, 2016
@hayatoito
Fix web-platform-tests#3193. Remove console.log and unnecessary utili…
4a0a4bb 
…ty functions
ivanzr pushed a commit to ivanzr/web-platform-tests that referenced this issue Jun 29, 2016
@hayatoito @ivanzr
Fix web-platform-tests#3193. Remove console.log and unnecessary utili…
6b4ee1f 
…ty functions (web-platform-tests#3204)
ddorwin pushed a commit to ddorwin/web-platform-tests that referenced this issue Sep 13, 2016
@hayatoito @ddorwin
Fix web-platform-tests#3193. Remove console.log and unnecessary utili…
9a00fd1 
…ty functions (web-platform-tests#3204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hayatoito hayatoito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hayatoito @zcorpan