Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css/cssom/CSSStyleSheet-constructable-concat.html is both a testharness test _and_ a reftest #43303

Closed
nt1m opened this issue Nov 22, 2023 · 2 comments
Closed

css/cssom/CSSStyleSheet-constructable-concat.html is both a testharness test _and_ a reftest #43303

nt1m opened this issue Nov 22, 2023 · 2 comments
Labels
cssom

Comments

@nt1m
Copy link
Member

nt1m commented Nov 22, 2023

The test contains:

<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>

and

<link rel="match" href="CSSStyleSheet-constructable-concat-ref.html">

We discovered this, because it trips up the WebKit test importer.

@mfreed7 Was this meant to be a testharness test or a reftest?
@karlcow karlcow mentioned this issue Nov 22, 2023
Merged
@mfreed7
Copy link
Contributor

mfreed7 commented Nov 22, 2023

@mfreed7 Was this meant to be a testharness test or a reftest?

Ugh, not sure what I was going for there. Looks like both. I think maybe I'll just convert to a reftest. Patch coming soon...

Merged
chromium-wpt-export-bot pushed a commit that referenced this issue Nov 22, 2023
@chromium-wpt-export-bot
Remove testharness from reftest
9b3e062 
I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] #43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
@mfreed7
Copy link
Contributor

mfreed7 commented Nov 22, 2023

#43310

aarongable pushed a commit to chromium/chromium that referenced this issue Nov 22, 2023
Remove testharness from reftest
4b3659b 
I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] web-platform-tests/wpt#43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055427
Commit-Queue: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228158}
chromium-wpt-export-bot pushed a commit that referenced this issue Nov 22, 2023
@chromium-wpt-export-bot
Remove testharness from reftest
a51e6fc 
I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] #43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055427
Commit-Queue: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228158}
chromium-wpt-export-bot pushed a commit that referenced this issue Nov 22, 2023
@chromium-wpt-export-bot
Remove testharness from reftest
e8e0556 
I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] #43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055427
Commit-Queue: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228158}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 30, 2023
@moz-wptsync-bot
Bug 1866137 [wpt PR 43310] - Remove testharness from reftest, a=testonly
c0fcc53 
Automatic update from web-platform-tests
Remove testharness from reftest

I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] web-platform-tests/wpt#43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055427
Commit-Queue: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228158}

--

wpt-commits: e8e0556f5ce4c1fec9ef0340e14d0cfa56d001c9
wpt-pr: 43310
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 30, 2023
@moz-wptsync-bot
Bug 1866137 [wpt PR 43310] - Remove testharness from reftest, a=testonly
9a1f559 
Automatic update from web-platform-tests
Remove testharness from reftest

I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] web-platform-tests/wpt#43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055427
Commit-Queue: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228158}

--

wpt-commits: e8e0556f5ce4c1fec9ef0340e14d0cfa56d001c9
wpt-pr: 43310
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 30, 2023
@marco-c
Bug 1866137 [wpt PR 43310] - Remove testharness from reftest, a=testonly
43b3f9a 
Automatic update from web-platform-tests
Remove testharness from reftest

I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] web-platform-tests/wpt#43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055427
Commit-Queue: Mason Freed <masonfchromium.org>
Commit-Queue: Joey Arhar <jarharchromium.org>
Auto-Submit: Mason Freed <masonfchromium.org>
Reviewed-by: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/main{#1228158}

--

wpt-commits: e8e0556f5ce4c1fec9ef0340e14d0cfa56d001c9
wpt-pr: 43310

UltraBlame original commit: 58087d221478dbbb0154b660e20b62de4f9db137
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 30, 2023
@marco-c
Bug 1866137 [wpt PR 43310] - Remove testharness from reftest, a=testonly
c111f35 
Automatic update from web-platform-tests
Remove testharness from reftest

I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] web-platform-tests/wpt#43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055427
Commit-Queue: Mason Freed <masonfchromium.org>
Commit-Queue: Joey Arhar <jarharchromium.org>
Auto-Submit: Mason Freed <masonfchromium.org>
Reviewed-by: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/main{#1228158}

--

wpt-commits: e8e0556f5ce4c1fec9ef0340e14d0cfa56d001c9
wpt-pr: 43310

UltraBlame original commit: 58087d221478dbbb0154b660e20b62de4f9db137
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 30, 2023
@marco-c
Bug 1866137 [wpt PR 43310] - Remove testharness from reftest, a=testonly
af37df4 
Automatic update from web-platform-tests
Remove testharness from reftest

I somehow made this both a testharness test and a reftest. This
CL converts this to just a reftest, to avoid breaking things [1].

[1] web-platform-tests/wpt#43303

Bug: 1236777
Change-Id: I89fc76e68a24ab12c4a9efeaac36183dfb85b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055427
Commit-Queue: Mason Freed <masonfchromium.org>
Commit-Queue: Joey Arhar <jarharchromium.org>
Auto-Submit: Mason Freed <masonfchromium.org>
Reviewed-by: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/main{#1228158}

--

wpt-commits: e8e0556f5ce4c1fec9ef0340e14d0cfa56d001c9
wpt-pr: 43310

UltraBlame original commit: 58087d221478dbbb0154b660e20b62de4f9db137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cssom
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsnedders @nt1m @mfreed7