Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLHttpRequest/abort-event-order.htm test incorrect #958

Closed
caitp opened this issue May 5, 2014 · 0 comments · Fixed by #959
Closed

XMLHttpRequest/abort-event-order.htm test incorrect #958

caitp opened this issue May 5, 2014 · 0 comments · Fixed by #959

Comments

@caitp
Copy link
Contributor

caitp commented May 5, 2014

The expected result is impossible to attain due to the structure of the test.

It expects the following collection

[1, 4, "upload.abort", "upload.loadend", "abort", "loadend"];

however it performs the assertion in the event handler in upload.onloadend(), and so the assertions are evaluated before the other events are dispatched.

This would have worked, prior to 10010b1 --- perhaps the Verify function needs to be moved as well?

I'll submit a quick patch for that, because yeah I'm fairly sure this is what was intended

caitp added a commit to caitp/web-platform-tests that referenced this issue May 5, 2014
Evaluate assertions at appropriate time in XMLHttpRequest/abort-event-order.html, to compliment
10010b1's corrected expected results

Closes web-platform-tests#958
caitp added a commit to caitp/web-platform-tests that referenced this issue May 5, 2014
Evaluate assertions at appropriate time in XMLHttpRequest/abort-event-order.html, to compliment
10010b1's corrected expected results

Closes web-platform-tests#958
gsnedders pushed a commit that referenced this issue Mar 28, 2017
…ests

[merge][css-grid] Fixed typo in minimum size tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant