[LayoutNG] Don't resolve unresolvable percentage min-height and max-height. #10019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 13, 2018
Build PASSEDStarted: 2018-03-14 06:41:25 View more information about this build on: |
…eight. We cannot use the content size (intrinsic block size) as min-height or max-height (min-width or max-width, if writing mode is vertical). Doing so would cause min-height to incorrectly override any specified height or max-height that is less than the intrinsic block size, and max-height to override any specified height that's greater than the intrinsic block size. Do what the spec says [1] instead: max-height to become 'none', and min-height to become 0. This fixes the final rendering problem with Acid2 (this was about the min-height issue). It now renders correctly with LayoutNG! Since no other tests than Acid2 started to pass with this change, I wrote a couple. [1] https://www.w3.org/TR/CSS22/visudet.html#min-max-heights XXXXXX XX XX X X X O O X X X X /\ X X \/ X X X X X X X X XXXXXXXX X X X XX XX XXXXXX Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic4f2c3c1dbc2bd66956ed4b270b08058999bc351 Reviewed-on: https://chromium-review.googlesource.com/960085 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#543018}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-960085
branch
from
eb3a3c4
to
2eafc77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use the content size (intrinsic block size) as min-height or
max-height (min-width or max-width, if writing mode is vertical).
Doing so would cause min-height to incorrectly override any specified
height or max-height that is less than the intrinsic block size, and
max-height to override any specified height that's greater than the
intrinsic block size. Do what the spec says [1] instead: max-height
to become 'none', and min-height to become 0.
This fixes the final rendering problem with Acid2 (this was about the
min-height issue). It now renders correctly with LayoutNG!
Since no other tests than Acid2 started to pass with this change, I wrote
a couple.
[1] https://www.w3.org/TR/CSS22/visudet.html#min-max-heights
XX XX
X X
X O O X
X X
X /\ X
X / X
X X
X X X X
X XXXXXXXX X
X X
XX XX
XXXXXX
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic4f2c3c1dbc2bd66956ed4b270b08058999bc351
Reviewed-on: https://chromium-review.googlesource.com/960085
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Aleks Totic atotic@chromium.org
Reviewed-by: Emil A Eklund eae@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#543018}