Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wptrunner: Always restart on test error #10186

Closed
wants to merge 1 commit into from
Closed

wptrunner: Always restart on test error #10186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion tools/wptrunner/wptrunner/testrunner.py
View file
Open in desktop
Expand Up @@ -254,6 +254,8 @@ class _RunnerManagerState(object):


class TestRunnerManager(threading.Thread):
statuses_requiring_restart = ("CRASH", "ERROR", "EXTERNAL-TIMEOUT")

def __init__(self, suite_name, test_queue, test_source_cls, browser_cls, browser_kwargs,
executor_cls, executor_kwargs, stop_flag, rerun=1, pause_after_test=False,
pause_on_unexpected=False, restart_on_unexpected=True, debug_info=None):
Expand Down Expand Up @@ -585,7 +587,7 @@ def test_ended(self, test, results):
extra=file_result.extra)

restart_before_next = (test.restart_after or
file_result.status in ("CRASH", "EXTERNAL-TIMEOUT") or
file_result.status in self.statuses_requiring_restart or
((subtest_unexpected or is_unexpected) and
self.restart_on_unexpected))

Expand Down