Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaymentRequest "paymentmethodchanged" event #10912

Merged
merged 14 commits into from
Jun 14, 2018
Merged

PaymentRequest "paymentmethodchanged" event #10912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
22d3794
Test PaymentRequest.onpaymentmenthodchange attr
marcoscaceres May 9, 2018
7412321
test PaymentRequest.methodDetails attr
marcoscaceres May 9, 2018
4a17712
test PaymentRequest.methodName attr
marcoscaceres May 9, 2018
0f9fc77
Remove copyright pasta
marcoscaceres May 10, 2018
fcb8fab
No basic card support for this
marcoscaceres May 10, 2018
f70f5a1
methodDetails attribute moved to PaymentMethodChangeEvent
marcoscaceres May 22, 2018
b90f717
moved to PaymentMethodChangeEvent.methodName
marcoscaceres May 22, 2018
5eb8ca3
Test for PaymentMethodChangeEvent.methodDetails
marcoscaceres May 22, 2018
65ca97b
Test for PaymentMethodChangeEvent.methodName
marcoscaceres May 22, 2018
eb34a27
Use PaymentMethodChangeEvent interface
marcoscaceres May 23, 2018
773c20a
Add test suggested by @domenic
marcoscaceres May 23, 2018
99cbcd2
lint: ignore CONTENT-VISUAL for pament test
marcoscaceres Jun 12, 2018
fa14f79
fixed missing src
marcoscaceres Jun 12, 2018
4375122
Revert "lint: ignore CONTENT-VISUAL for pament test"
marcoscaceres Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 21 additions & 0 deletions payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Test for PaymentMethodChangeEvent.methodDetails attribute</title>
<link rel="help" href="https://w3c.github.io/browser-payment-api/#dom-paymentmethodchangeevent-methoddetails">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
"use strict";
test(() => {
const methodDetails = {
test: "pass"
}
const event = new PaymentMethodChangeEvent("test", {
methodName: "wpt-test",
methodDetails
});
assert_idl_attribute(event, "methodDetails");
const { test } = event.methodDetails;
assert_equals(test, "pass");
assert_equals(event.methodDetails, methodDetails);
}, "Must have a methodDetails IDL attribute, which is initialized with to the methodName dictionary value");
16 changes: 16 additions & 0 deletions payment-request/PaymentMethodChangeEvent/methodName-attribute.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Test for PaymentMethodChangeEvent.methodName attribute</title>
<link rel="help" href="https://w3c.github.io/browser-payment-api/#dom-paymentmethodchangeevent-src">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
"use strict";
test(() => {
const event = new PaymentMethodChangeEvent("test", {
methodName: "wpt-test",
});
assert_idl_attribute(event, "methodName");
const { methodName } = event;
assert_equals(methodName, "wpt-test");
}, "Must have a methodName IDL attribute, which is initialized with to the methodName dictionary value");
70 changes: 70 additions & 0 deletions payment-request/onpaymentmenthodchange-attribute.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Test for onpaymentmethodchange attribute</title>
<link rel="help" href="https://w3c.github.io/browser-payment-api/#onpaymentmethodchange-attribute">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
"use strict";
const testMethod = Object.freeze({ supportedMethods: "not-a-real-method" });
const applePay = Object.freeze({ supportedMethods: "https://apple.com/apple-pay" });
const defaultMethods = Object.freeze([testMethod, applePay]);
const defaultDetails = Object.freeze({
total: {
label: "Total",
amount: {
currency: "USD",
value: "1.00",
},
},
});

test(() => {
const request = new PaymentRequest(defaultMethods, defaultDetails);
assert_idl_attribute(request, "onpaymentmethodchange");
}, "Must have a onpaymentmethodchange IDL attribute");

test(() => {
const request = new PaymentRequest(defaultMethods, defaultDetails);
const ev = new Event("paymentmethodchange");
let didHandle = false;
request.onpaymentmethodchange = evt => {
assert_equals(ev, evt, "must be same event");
didHandle = true;
};
request.dispatchEvent(ev);
assert_true(didHandle, "event did not fire");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I thought generally the assertion message should say what should be true (e.g. "must be same event") but for many you are indicating what doesn't happen if it fails.

e.g. this should be "event fired"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a bit all over the place and a matter of preference. The messages only show up when tests fail, so I tend to explain why something failed rather than why something passed. So:

Why did X fail? ..."event did not fire".

}, `onpaymentmethodchange attribute is a generic handler for "paymentmethodchange"`);

test(() => {
const request = new PaymentRequest(defaultMethods, defaultDetails);
const ev = new PaymentMethodChangeEvent("paymentmethodchange");
let didHandle = false;
request.onpaymentmethodchange = evt => {
assert_equals(ev, evt, "must be same event");
didHandle = true;
};
request.dispatchEvent(ev);
assert_true(didHandle, "event did not fire");
}, `onpaymentmethodchange attribute is a handler for PaymentMethodChangeEvent`);

test(() => {
const request = new PaymentRequest(defaultMethods, defaultDetails);
const ev = new PaymentMethodChangeEvent("paymentmethodchange", {
methodName: "test"
});
let didHandle = false;
let didListen = false;
request.onpaymentmethodchange = evt => {
assert_equals(ev, evt, "must be same event");
didHandle = true;
};
request.addEventListener("paymentmethodchange", evt => {
assert_equals(ev, evt, "must be same event");
didListen = true;
});
request.dispatchEvent(ev);
assert_true(didHandle, "onpaymentmethodchange did not receive the event");
assert_true(didListen, "addEventListener did not receive the event");
}, `onpaymentmethodchange attribute and listeners both work`);
</script>