Update Web Platform Tests for Feature Policy integration into HTML spec. #10966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 11, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1053106
branch
from
47a3471
to
3e22be5
Compare
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Jun 22, 2018
This commit introduces the feature policy for Document objects, adds the 'allow' attribute to iframe elements, and reframes 'allowfullscreen', 'allowpaymentrequest' and 'allowusermedia' in terms of feature policy. Document allow* flags are removed, as they are no longer referenced. The 'allowed to use' algorithm is also updated to call into the feature policy 'Is feature enabled' algorithm, and rewritten to take a policy- controlled feature as an argument rather than an attribute, so that other specs can also use it to control other features. Tests: - web-platform-tests/wpt#10966 - web-platform-tests/wpt@3cc0d89 - web-platform-tests/wpt@9a00e4a - web-platform-tests/wpt#4625
Change-Id: Ibfcc3e8bc217aff8782d2aec4c1b73bb4a193e1e Reviewed-on: https://chromium-review.googlesource.com/1053106 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#569778}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1053106
branch
from
3e22be5
to
47b04c8
Compare
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
This commit introduces the feature policy for Document objects, adds the 'allow' attribute to iframe elements, and reframes 'allowfullscreen', 'allowpaymentrequest' and 'allowusermedia' in terms of feature policy. Document allow* flags are removed, as they are no longer referenced. The 'allowed to use' algorithm is also updated to call into the feature policy 'Is feature enabled' algorithm, and rewritten to take a policy- controlled feature as an argument rather than an attribute, so that other specs can also use it to control other features. Tests: - web-platform-tests/wpt#10966 - web-platform-tests/wpt@3cc0d89 - web-platform-tests/wpt@9a00e4a - web-platform-tests/wpt#4625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ibfcc3e8bc217aff8782d2aec4c1b73bb4a193e1e
Reviewed-on: https://chromium-review.googlesource.com/1053106
Commit-Queue: Ian Clelland iclelland@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#569778}