Add basic marker on shape tests. #10993
Conversation
wpt-pr-bot
requested review from
AmeliaBR,
boggydigital,
ewilligers,
heycam,
nikosandronikos and
svgeesus
| title="NAME_OF_REVIEWER" | ||
| href="mailto:EMAIL OR http://CONTACT_PAGE" /> | ||
| <!-- YYYY-MM-DD --> | ||
| <html:link rel="help" |
There was a problem hiding this comment.
remove rel=help from test references (applies to all references in this PR)
| href="https://www.w3.org/TR/SVG2/painting.html#Markers"/> | ||
| <html:link rel="match" href="marker-shape-001-ref.svg" /> | ||
| <metadata class="flags">TOKENS</metadata> | ||
| <desc class="assert">TEST ASSERTION</desc> |
There was a problem hiding this comment.
If possible, add an actual test assertion. If not, delete the boilerplate assertion.
| xmlns:xlink="http://www.w3.org/1999/xlink" | ||
| xmlns:html="http://www.w3.org/1999/xhtml"> | ||
| <g id="testmeta"> | ||
| <title>Hatch: Basic hatch.</title> |
There was a problem hiding this comment.
These tests are not about hatch
There was a problem hiding this comment.
Remove the unused font style information.
It shouldn't prevent merging of this PR, but:
There should really be tests for all the basic shapes, and those will need to be more specific than just comparing against a matching path (because some browsers currently paint too many markers for arcs in paths).
|
See discussion in w3c/svgwg#753 about possibly changing some of the spec behavior, which could affect these tests. |
|
I've added circle/ellipse tests. And removed unused style element. |
…d-marker at start/end of path equivalent for shapes. Use straight lines for markers in reference SVGs to avoid rendering error by some browsers (too many markers on curves). Fixed bad SVG for circle/ellipse test SVGs.
Basic marker on shape tests.