Fix errors external/wpt/RTCPeerConnection-removeTrack.https.html. #11459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 11, 2018
This is in preparation for RTCRtpTransceiver/Unified Plan support.
"Calling removeTrack with valid sender should set sender.track to null"
Asserting that direction changes from 'sendrecv' to 'recvonly', this
is explicit in the spec[1].
"Calling removeTrack with currentDirection blah should set direction to
blah"
The tests that meant to set up currentDirection to be 'sendrecv' or
'recvonly' before removeTrack() were incorrect. Tests updated to set
up currentDirection correctly. Also updated them to use async/await
because that's much nicer.
These all fail because we don't have transceivers yet, but when running
these changes in the RTCRtpTransceiver WIP CL[2], they all pass.
[1] See step 10 of
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-removetrack
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1025771/
Bug: 777617
Change-Id: Ie3c077d14ea30038a06a98ecbeea475ac824dd9c
Reviewed-on: https://chromium-review.googlesource.com/1095275
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566366}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1095275
branch
from
9d9cbf4
to
e51f84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for RTCRtpTransceiver/Unified Plan support.
"Calling removeTrack with valid sender should set sender.track to null"
Asserting that direction changes from 'sendrecv' to 'recvonly', this
is explicit in the spec[1].
"Calling removeTrack with currentDirection blah should set direction to
blah"
The tests that meant to set up currentDirection to be 'sendrecv' or
'recvonly' before removeTrack() were incorrect. Tests updated to set
up currentDirection correctly. Also updated them to use async/await
because that's much nicer.
These all fail because we don't have transceivers yet, but when running
these changes in the RTCRtpTransceiver WIP CL[2], they all pass.
[1] See step 10 of
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-removetrack
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1025771/
Bug: 777617
Change-Id: Ie3c077d14ea30038a06a98ecbeea475ac824dd9c
Reviewed-on: https://chromium-review.googlesource.com/1095275
Reviewed-by: Guido Urdaneta guidou@chromium.org
Commit-Queue: Henrik Boström hbos@chromium.org
Cr-Commit-Position: refs/heads/master@{#566366}