Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sensors] Bring setUpdateSensorReadingFunction from sensor mojo inter… #11600

Closed
wants to merge 2 commits into from
Closed

[sensors] Bring setUpdateSensorReadingFunction from sensor mojo inter… #11600

wants to merge 2 commits into from

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Jun 21, 2018

…face

to provide the mock values for sensors

@Honry Honry requested a review from rakuco June 21, 2018 06:24
@Honry
Copy link
Contributor Author

Honry commented Jun 21, 2018

@rakuco, PTAL, thanks!

@rakuco
Copy link
Member

rakuco commented Jun 22, 2018

These changes are quite big and intrusive. Is there anything in specific that this is supposed to fix? If so, can we import only the relevant part of the diff?

@Honry
Copy link
Contributor Author

Honry commented Jun 25, 2018 •
edited

@rakuco, this brings setUpdateSensorReadingFunction method from blink's own sensor-helpers.js, which allows user customization of mock sensor's reading updates, for the purpose of verifying sensor readings exposed to Sensor API are expected.

Tests changes in this PR are referred to sensor LayoutTests with some modification, and I've verified it with latest chrome, all tests results are expected.

Changes in generic-sensor-tests.js involve all sensors tests, that's why it looks big. :(
Sorry for the inconvenience. I will try to simplified it, but pls. don't expect there would be a big reduction.

@Honry Honry force-pushed the mock-update-reading branch 2 times, most recently from 7369f35 to d1ed272 Compare June 26, 2018 02:41
@Honry Honry mentioned this pull request Sep 7, 2018
Closed
@Honry
Copy link
Contributor Author

Honry commented Sep 17, 2019

This is abandoned and replaced with #18886.

@Honry Honry closed this Sep 17, 2019
@Honry Honry deleted the mock-update-reading branch September 17, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakuco rakuco Awaiting requested review from rakuco

Assignees

@anssiko anssiko

Labels
accelerometer ambient-light generic-sensor geolocation-sensor gyroscope infra magnetometer orientation-sensor proximity wg-das
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Honry @rakuco @anssiko @wpt-pr-bot