Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sensors] Bring setUpdateSensorReadingFunction from sensor mojo inter… #11600

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Honry
Copy link
Contributor

commented Jun 21, 2018

…face

to provide the mock values for sensors

@Honry

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

@rakuco, PTAL, thanks!

@rakuco

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2018

These changes are quite big and intrusive. Is there anything in specific that this is supposed to fix? If so, can we import only the relevant part of the diff?

@Honry

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2018

@rakuco, this brings setUpdateSensorReadingFunction method from blink's own sensor-helpers.js, which allows user customization of mock sensor's reading updates, for the purpose of verifying sensor readings exposed to Sensor API are expected.

Tests changes in this PR are referred to sensor LayoutTests with some modification, and I've verified it with latest chrome, all tests results are expected.

Changes in generic-sensor-tests.js involve all sensors tests, that's why it looks big. :(
Sorry for the inconvenience. I will try to simplified it, but pls. don't expect there would be a big reduction.

@Honry Honry force-pushed the Honry:mock-update-reading branch 2 times, most recently from 7369f35 to d1ed272 Jun 25, 2018

@Honry Honry force-pushed the Honry:mock-update-reading branch from d1ed272 to 772b0c3 Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.